Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude mem store from commit info #14931

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

alexanderbez
Copy link
Contributor

Description

Closes: #14916

Exclude in-mem KVStore from Commit info commitments.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review February 6, 2023 22:24
@alexanderbez alexanderbez requested a review from a team as a code owner February 6, 2023 22:24
@github-prbot github-prbot requested review from a team, aaronc and facundomedica and removed request for a team February 6, 2023 22:24
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Feb 6, 2023
@tac0turtle tac0turtle merged commit 1344ff1 into main Feb 7, 2023
@tac0turtle tac0turtle deleted the bez/14916-remove-mem-ci branch February 7, 2023 04:09
mergify bot pushed a commit that referenced this pull request Feb 7, 2023
(cherry picked from commit 1344ff1)

# Conflicts:
#	CHANGELOG.md
#	store/rootmulti/store.go
tac0turtle added a commit that referenced this pull request Feb 7, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't include mem stores in commitInfo(app hash)
3 participants