Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Comet from modules and storage #17425

Closed
9 of 14 tasks
Tracked by #17045
tac0turtle opened this issue Aug 17, 2023 · 3 comments
Closed
9 of 14 tasks
Tracked by #17045

Decouple Comet from modules and storage #17425

tac0turtle opened this issue Aug 17, 2023 · 3 comments
Labels
C: comet C:server/v2 Issues related to server/v2 T:tech debt Tech debt that should be cleaned up

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Aug 17, 2023 •
edited
Loading

This issue is aimed at removing the comet dependency in modules and other areas of the Cosmos SDK.

We would like to remove the dependence in order to allow teams to use the Cosmos SDK without needing to rely on comet as a dependency themself. Secondly this allows comet integration into the sdk and mainnets to be quicker and streamlined

  • storage
  • auth
  • authz
  • accounts
  • evidence
  • circuit
  • distribution
  • staking
  • slashing
  • gov
  • upgrade
  • feegrant
  • mint
  • protocolpool
@tac0turtle tac0turtle mentioned this issue Aug 17, 2023
Closed
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Aug 17, 2023
@tac0turtle tac0turtle added C: comet T:tech debt Tech debt that should be cleaned up and removed needs-triage Issue that needs to be triaged labels Aug 17, 2023
@tac0turtle tac0turtle mentioned this issue Aug 17, 2023
Merged
20 tasks
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Aug 18, 2023
This was referenced Aug 27, 2023
Merged
Closed
@tac0turtle tac0turtle moved this to To Do in Cosmos-SDK Oct 6, 2023
@facundomedica facundomedica mentioned this issue Oct 26, 2023
Merged
20 tasks
@tac0turtle tac0turtle added the C:server/v2 Issues related to server/v2 label Feb 20, 2024
@tac0turtle
Copy link
Member Author

removed from olympus since this is not required

@raynaudoe
Copy link
Contributor

Hey @tac0turtle I can remove all the cometbft/cometbft/crypto deps inside the sdk.
It would also be a healthy thing prior to crypto/v2.

@coderabbitai coderabbitai bot mentioned this issue May 1, 2024
Merged
12 tasks
@tac0turtle tac0turtle mentioned this issue May 3, 2024
Merged
12 tasks
@raynaudoe raynaudoe mentioned this issue Jun 25, 2024
Closed
12 tasks
@coderabbitai coderabbitai bot mentioned this issue Sep 10, 2024
Merged
12 tasks
@tac0turtle
Copy link
Member Author

completed here #21382

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: comet C:server/v2 Issues related to server/v2 T:tech debt Tech debt that should be cleaned up
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raynaudoe @tac0turtle @samricotta