-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpackages for x/modules #1779
Comments
I'm not convinced the slashing module will get much more complicated - most of the complicated slashing logic is in the staking module, since it needs access to un-exported keeper functions - maybe we could consider refactoring that somehow. Agreed for governance, and for slashing if we think it will get more complicated; at the moment I think slashing subpackages would be overkill. |
cool - you should def. make the judgement call for |
I think @rigelrozanski's recent PR refactoring the modules handles this. Going to go ahead and close. |
duplicate of #1124 |
* add tests for evidence * query evidence by hash * fix some typos * use global constants to avoid duplicated string * add constant for the query command * build url inline Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
organize core modules to have sub-packages (see
x/stake
which has been organized this way) - it's really good to set the this type of structure early on in the development - I know slashing and governance are probably going to grow up to be big complicated machines, doing this refactor for staking (which was quite mature at the time) was a bit of a headache I think we should perform a similar refactors forgov
andslashing
at a minimum in the short term to alleviate future migraines.@sunnya97 @cwgoes
The text was updated successfully, but these errors were encountered: