Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subpackages for x/modules #1779

Closed
rigelrozanski opened this issue Jul 20, 2018 · 4 comments
Closed

Subpackages for x/modules #1779

rigelrozanski opened this issue Jul 20, 2018 · 4 comments

Comments

@rigelrozanski
Copy link
Contributor

organize core modules to have sub-packages (see x/stake which has been organized this way) - it's really good to set the this type of structure early on in the development - I know slashing and governance are probably going to grow up to be big complicated machines, doing this refactor for staking (which was quite mature at the time) was a bit of a headache I think we should perform a similar refactors for gov and slashing at a minimum in the short term to alleviate future migraines.

@sunnya97 @cwgoes

@cwgoes
Copy link
Contributor

cwgoes commented Jul 20, 2018

I'm not convinced the slashing module will get much more complicated - most of the complicated slashing logic is in the staking module, since it needs access to un-exported keeper functions - maybe we could consider refactoring that somehow.

Agreed for governance, and for slashing if we think it will get more complicated; at the moment I think slashing subpackages would be overkill.

@rigelrozanski
Copy link
Contributor Author

cool - you should def. make the judgement call for x/slashing - I will mention however, that if things start creeping to be more complex in slashing, at that point we should first refactor

@jackzampolin
Copy link
Member

I think @rigelrozanski's recent PR refactoring the modules handles this. Going to go ahead and close.

@rigelrozanski
Copy link
Contributor Author

duplicate of #1124

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
* add tests for evidence

* query evidence by hash

* fix some typos

* use global constants to avoid duplicated string

* add constant for the query command

* build url inline

Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants