You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
baseapp: Init contradictorily checks if app.cms == nil after invoking app.setState which blindly dereferences app.cms + app.Seal which will cause nil pointer panics or prevent any progress since sealed=true
#18726
Closed
odeke-em opened this issue
Dec 13, 2023
· 0 comments
· Fixed by #18727
returnerrors.New("commit multi-store must not be nil")
}
That's a contradiction right there and would result in a nil panic, even more by invoking app.Seal() firstly we make it so that any failure thats fixed by now setting a cms then that's rechecked then .Init() is retried will just fail with no meaningful progress. We should move that check up before setState
The text was updated successfully, but these errors were encountered:
If we examine this code
cosmos-sdk/baseapp/baseapp.go
Lines 429 to 437 in 570ab64
cosmos-sdk/baseapp/baseapp.go
Line 481 in 570ab64
But later down we have a check for app.cms == nil
cosmos-sdk/baseapp/baseapp.go
Lines 433 to 436 in 570ab64
That's a contradiction right there and would result in a nil panic, even more by invoking app.Seal() firstly we make it so that any failure thats fixed by now setting a cms then that's rechecked then .Init() is retried will just fail with no meaningful progress. We should move that check up before setState
The text was updated successfully, but these errors were encountered: