Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Usage of Client Provided Account Number/Sequence in Context Query #1903

Closed
2 of 4 tasks
alexanderbez opened this issue Aug 1, 2018 · 4 comments
Closed
2 of 4 tasks

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Aug 1, 2018

Summary

The current refactor of #1741 contains utils.SendTx which does a lookup of an account number and sequence if the respective provided CLI arguments are 0. Majority of all CLI command implementations use utils.SendTx.

Problem Definition

A client should be able to specify 0 as an account number and/or sequence without utils.SendTx automatically doing a lookup.

Proposal

Implement some notion of determining when a user actually specified these values via the command line and allowing them through. This will most likely involve moving this logic out of utils and some some viper work somewhere else.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cwgoes
Copy link
Contributor

cwgoes commented Aug 2, 2018

Might be post-launch, as I think Viper just doesn't do this correctly - spf13/viper#276.

Ref #1206.

@ValarDragon
Copy link
Contributor

I think we can just make the default value -1. Negative values meaning automatic isn't super uncommon. (though perhaps a bit of an anti-pattern)

@alexanderbez
Copy link
Contributor Author

True, that is an option. Although, the UX would be a bit...weird...with the -1 default value in the CLI description.

@jackzampolin
Copy link
Member

Closing as this has been addressed.

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
* fix the code test coverage measure

* fix folder type removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants