Check Ledger app version in gaiacli

[cwgoes]

In case we later release incompatible versions, then we can warn the user.

[alessio]

How do we go about it? Do we want to create a new command for that or implement a version check in gaiacli keys sub-commands that support ledger devices?

[alexanderbez]

I think gaiacli keys add ... --ledger should warn the user of incompatible version(s).

[cwgoes]

I think it should maybe even refuse to proceed in case of incompatible version, unless the user passes an opt-in flag to override the version check.

[alexanderbez]

💯 agree. I think this is a good UX.

[alessio]

Currently, ledger client returns the following:

&{AppId:0 Major:1 Minor:0 Patch:0}

Is that acceptable to check only against Major == 1?

[cwgoes]

Since we choose the version, that seems fine for now.

[alessio]

I believe this #2870 would close this

[cwgoes]

Does #2870 check the version (in the updated library) and throw an error on mismatch?

[alessio]

https://github.com/ZondaX/ledger-cosmos-go/blob/master/user_app.go#L63

[alessio]

It does what I proposed above. Checking whether the major version => a required one