Add Ledger support indicator to the version command (maybe ledger version too?)

[greg-szabo]

Summary

I need to know if a binary was built with ledger support or not.

Problem Definition

First idea was to check the version command. Since it gives an overall picture of the binary it would be nice if the support was indicated there. Maybe even the ledger version number if there is such a thing. (See also similar discussion for gaiacli here.)

Proposal

Currently:

cosmos-sdk: 0.30.0-0-ge003c5e
git commit: e003c5ebe02bed51056e46d5ff1a232e2bd00dda
vendor hash: ff0167e16651127cb1f75144c76f61fe626d029f
go version go1.11.5 linux/amd64

After feature:

[centos@validator ~]$ /usr/bin/gaiad version
cosmos-sdk: 0.30.0-0-ge003c5e
git commit: e003c5ebe02bed51056e46d5ff1a232e2bd00dda
vendor hash: ff0167e16651127cb1f75144c76f61fe626d029f
go version go1.11.5 linux/amd64
Ledger support: enabled

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[jleni]

The ledger-cosmo-go lib includes info about which is the minimum firmware that is supported.

https://github.com/ZondaX/ledger-cosmos-go/blob/69fdb8ce5e5b9d9c3b22b9248e117b231d4f06dd/user_app.go#L39-L41

I could expose this in the API and show it in gaia as you are requesting.

[jleni]

gaiad will never have ledger support. Ledger support is limited to gaia CLI.
Determining required ledger app version needs code execution, etc.
I would suggest to initially show the build tags as done in the referenced PR.

[jleni]

After PR #3620, it is possible to see which build flags have been used:

cosmos-sdk: 0.31.1-10-gfe548c08
git commit: fe548c0
vendor hash: 1aec7edfad9888a967b3e9063e42f66b28f447e6
build tags: netgo ledger
go version go1.11.5 linux/amd64

@greg-szabo The required version number varies depending on the functionality requested. A CLI error message will indicate if the currently running app is not supported.

Do you think we can close this issue now?