Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/v2: wire grpc and gateway #20798

Closed
2 tasks done
Tracked by #20439
tac0turtle opened this issue Jun 27, 2024 · 3 comments · Fixed by #21038
Closed
2 tasks done
Tracked by #20439

server/v2: wire grpc and gateway #20798

tac0turtle opened this issue Jun 27, 2024 · 3 comments · Fixed by #21038
Labels
C:server/v2 Issues related to server/v2 T: Client UX

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jun 27, 2024

@tac0turtle tac0turtle changed the title wire grpc and gateway server/v2: wire grpc and gateway Jun 27, 2024
@julienrbrt julienrbrt self-assigned this Jun 27, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 27, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Jun 27, 2024
@tac0turtle tac0turtle added T: Client UX C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels Jun 28, 2024
@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jul 18, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Jul 30, 2024
@julienrbrt julienrbrt reopened this Aug 29, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 📋 Backlog in Cosmos-SDK Aug 29, 2024
@julienrbrt
Copy link
Member

Wouldn't we able to use the rest v2 (post endpoint) server, and proxy query to it?
Basically, an http handler that split the request path, and checks the proto registry matching Service, and make Post a request from the server for it?

That will be hacky, but does sound possible. That will be probably less efficient than the new rest endpoint, but will be good enough for those willing backward compat.

@julienrbrt
Copy link
Member

Given that #22701 did the wiring, closing this as completed.
I'll create another issue with the way we wanted to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2 T: Client UX
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

3 participants