-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to grpc-gateway V2 #8055
Comments
Note that grpc-gateway in v2 defaults to camelCase, which is also the default ProtoJSON spec case. We should make a decision whether to switch to camelCase everywhere (con: huge client breaking change) or stick with camel_case (con: not following SPEC). My preference is to eventually switch to camelCase, so that we don't have inconsistencies anymore, see e.g. ( (credits to @haveanicedavid for flagging this) |
I believe this will only be possible once we migrate away from gogo to google.golang.org/protobuf. |
I personally hate seeing camel-case in JSON, but this is what Google recommends so 🤷 |
I really would prefer to stick to the proto names for fields in JSON. It is configurable and I think we should take advantage of that. |
Is that something we should do while adding it to server/v2? |
The support of gRPC gateway is v2 will be done differently as we want to remove the gRPC registration requirement from modules. |
Summary
Upgrade to grpc-gateway V2
Problem Definition
From the author:
Proposal
Follow the migration guide.
For Admin Use
The text was updated successfully, but these errors were encountered: