Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to grpc-gateway V2 #8055

Closed
4 tasks
amaury1093 opened this issue Dec 1, 2020 · 6 comments
Closed
4 tasks

Upgrade to grpc-gateway V2 #8055

amaury1093 opened this issue Dec 1, 2020 · 6 comments
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. C:server/v2 Issues related to server/v2

Comments

@amaury1093
Copy link
Contributor

Summary

Upgrade to grpc-gateway V2

Problem Definition

From the author:

The grpc-gateway v1 is in maintenance mode, you are encouraged to migrate to v2. Check out our v2 migration guide.

Proposal

Follow the migration guide.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added REST C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. labels Dec 1, 2020
@aaronc aaronc moved this from Todo to Ice Box in Cosmos SDK: Framework WG Mar 29, 2022
@tac0turtle tac0turtle removed the REST label May 9, 2022
@amaury1093
Copy link
Contributor Author

amaury1093 commented Sep 7, 2022

Note that grpc-gateway in v2 defaults to camelCase, which is also the default ProtoJSON spec case.

We should make a decision whether to switch to camelCase everywhere (con: huge client breaking change) or stick with camel_case (con: not following SPEC).

My preference is to eventually switch to camelCase, so that we don't have inconsistencies anymore, see e.g. (totalWeight vs total_weight in the docs).

(credits to @haveanicedavid for flagging this)

@aaronc
Copy link
Member

aaronc commented Sep 7, 2022

I believe this will only be possible once we migrate away from gogo to google.golang.org/protobuf.

@alexanderbez
Copy link
Contributor

I personally hate seeing camel-case in JSON, but this is what Google recommends so 🤷

@aaronc
Copy link
Member

aaronc commented Sep 7, 2022

I personally hate seeing camel-case in JSON, but this is what Google recommends so 🤷

I really would prefer to stick to the proto names for fields in JSON. It is configurable and I think we should take advantage of that.

@julienrbrt
Copy link
Member

Is that something we should do while adding it to server/v2?
ref: #20798

cc @tac0turtle & @testinginprod

@julienrbrt julienrbrt added the C:server/v2 Issues related to server/v2 label Aug 29, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Aug 29, 2024
@julienrbrt
Copy link
Member

The support of gRPC gateway is v2 will be done differently as we want to remove the gRPC registration requirement from modules.
This is being tracked by #20798

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Ice Box to Done in Cosmos SDK: Framework WG Nov 19, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. C:server/v2 Issues related to server/v2
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

5 participants