Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement quick-n-dirty events in existing ABCI tag format #2448

Closed
cwgoes opened this issue Oct 5, 2018 · 5 comments
Closed

Implement quick-n-dirty events in existing ABCI tag format #2448

cwgoes opened this issue Oct 5, 2018 · 5 comments
Assignees
@alexanderbez
Labels
C:ABCI

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Oct 5, 2018 •
edited
Loading

Ref tendermint/tendermint#1859 (comment)

We need to change the keys in tags such that duplicate ones do not overwrite each other (as I believe that's how the Tendermint indexer works at the moment).
@cwgoes cwgoes mentioned this issue Oct 5, 2018
Closed
@jackzampolin
Copy link
Member

So this is back in scope for launch?

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 8, 2018

So this is back in scope for launch?

Hmm, I'm not sure what you mean? I think we took the ABCI events change out of scope for launch, but we still need to return e.g. slashing records somehow in the existing tag system - that's what this issue is for.

@cwgoes cwgoes mentioned this issue Nov 14, 2018
Closed
4 tasks
@alexanderbez alexanderbez mentioned this issue Nov 14, 2018
Closed
4 tasks
@hleb-albau
Copy link
Contributor

hleb-albau commented Nov 14, 2018 •
edited
Loading

ref #2770
We can create own events and events indexing system on cosmos-sdk side (and do not touch tendermint at all).

@cwgoes
Copy link
Contributor Author

cwgoes commented Dec 11, 2018

In particular, this needs to be done for:

  • Slashing (BeginBlock)
  • Governance tallies (EndBlock)

@alexanderbez alexanderbez self-assigned this Dec 11, 2018
This was referenced Dec 17, 2018
Merged
Closed
@alexanderbez
Copy link
Contributor

Closing this for now per discussions of this needing ABCI changes.

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@dependabot
chore(deps): bump actions/checkout from 3.3.0 to 3.5.2 (cosmos#2448)
493f1ef 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.3.0...v3.5.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:ABCI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hleb-albau @alexanderbez @jackzampolin @cwgoes