Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags.AppendTag do not work #2624

Closed
4 tasks
elvin-du opened this issue Oct 29, 2018 · 2 comments
Closed
4 tasks

Tags.AppendTag do not work #2624

elvin-du opened this issue Oct 29, 2018 · 2 comments
Labels
T:Bug

Comments

@elvin-du
Copy link
Contributor

Summary of Bug

Tags.AppendTag() function has syntax proplem, do not append elements.

Steps to Reproduce

for example:
never get "voting-period-start" tag, because of AppendTag() error.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon
Copy link
Contributor

To be more clear, the issue was we were not setting the variable to be the result of append tags in the calling functions.

@ValarDragon
Copy link
Contributor

Closed by #2643, thanks for catching this!

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@mpoke
bump liquidity to v1.6.0-forced-withdrawal-rc1 (cosmos#2624)
84fc0e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elvin-du @ValarDragon