remove 'err' names from function return arguments in queriers #2788
Labels
good first issue
help wanted
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Comments
5 tasks
fedekunze
added
Type: Code Hygiene
|
Yes pweeeez 🙌 Also, we should remove named return variables where it's obviously clear what the context is and the function/method is concise. |
5 tasks
|
@fedekunze & @alexanderbez has then been solved, seems the PR from 4ever9 solved most to all of them |
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this issue
Mar 1, 2024
…2788) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spf13/cobra/releases">github.com/spf13/cobra's releases</a>.</em></p> <blockquote> <h2>v1.8.0</h2> <h2>✨ Features</h2> <ul> <li>Support usage as plugin for tools like kubectl by <a href="https://github.com/nirs"><code>@nirs</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2018">spf13/cobra#2018</a> - this means that programs that utilize a "plugin-like" structure have much better support and usage (like for completions, command paths, etc.)</li> <li>Move documentation sources to site/content by <a href="https://github.com/umarcor"><code>@umarcor</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1428">spf13/cobra#1428</a></li> <li>Add 'one required flag' group by <a href="https://github.com/marevers"><code>@marevers</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1952">spf13/cobra#1952</a> - this includes a new <code>MarkFlagsOneRequired</code> API for flags which can be used to mark a flag group as required and cause command failure if at least one is not used when invoked.</li> <li>Customizable error message prefix by <a href="https://github.com/5ouma"><code>@5ouma</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2023">spf13/cobra#2023</a> - This adds the <code>SetErrPrefix</code> and <code>ErrPrefix</code> APIs on the <code>Command</code> struct to allow for setting a custom prefix for errors</li> <li>feat: add getters for flag completions by <a href="https://github.com/avirtopeanu-ionos"><code>@avirtopeanu-ionos</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1943">spf13/cobra#1943</a></li> <li>Feature: allow running persistent run hooks of all parents by <a href="https://github.com/vkhoroz"><code>@vkhoroz</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2044">spf13/cobra#2044</a></li> <li>Improve API to get flag completion function by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2063">spf13/cobra#2063</a></li> </ul> <h2>🐛 Bug fixes</h2> <ul> <li>Fix typo in fish completions by <a href="https://github.com/twpayne"><code>@twpayne</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1945">spf13/cobra#1945</a></li> <li>Fix grammar: 'allows to' by <a href="https://github.com/supertassu"><code>@supertassu</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1978">spf13/cobra#1978</a></li> <li>powershell: escape variable with curly brackets by <a href="https://github.com/Luap99"><code>@Luap99</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1960">spf13/cobra#1960</a></li> <li>Don't complete --help flag when flag parsing disabled by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2061">spf13/cobra#2061</a></li> <li>Replace all non-alphanumerics in active help env var program prefix by <a href="https://github.com/scop"><code>@scop</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1940">spf13/cobra#1940</a></li> </ul> <h2>🔧 Maintenance</h2> <ul> <li>build(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.5.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1971">spf13/cobra#1971</a></li> <li>build(deps): bump golangci/golangci-lint-action from 3.5.0 to 3.6.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1976">spf13/cobra#1976</a></li> <li>build(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2021">spf13/cobra#2021</a></li> <li>build(deps): bump actions/setup-go from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1934">spf13/cobra#1934</a></li> <li>build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.2 to 2.0.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2047">spf13/cobra#2047</a></li> <li>build(deps): bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2028">spf13/cobra#2028</a></li> <li>command: temporarily disable G602 due to <a href="https://redirect.github.com/securego/gosec/issues/1005">securego/gosec#1005</a> by <a href="https://github.com/umarcor"><code>@umarcor</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2022">spf13/cobra#2022</a></li> </ul> <h2>🧪 Testing & CI/CD</h2> <ul> <li>test: make fish_completions_test more robust by <a href="https://github.com/branchvincent"><code>@branchvincent</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1980">spf13/cobra#1980</a></li> <li>golangci: enable 'unused' and disable deprecated replaced by it by <a href="https://github.com/umarcor"><code>@umarcor</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1983">spf13/cobra#1983</a></li> <li>cleanup: minor corrections to unit tests by <a href="https://github.com/JunNishimura"><code>@JunNishimura</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2003">spf13/cobra#2003</a></li> <li>ci: test golang 1.21 by <a href="https://github.com/nunoadrego"><code>@nunoadrego</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2024">spf13/cobra#2024</a></li> <li>Fix linter errors by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2052">spf13/cobra#2052</a></li> <li>Add tests for flag completion registration by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2053">spf13/cobra#2053</a></li> </ul> <h2>✏️ Documentation</h2> <ul> <li>doc: fix typo, Deperecated -> Deprecated by <a href="https://github.com/callthingsoff"><code>@callthingsoff</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2000">spf13/cobra#2000</a></li> <li>Add notes to doc about the execution condition of *PreRun and *PostRun functions by <a href="https://github.com/haoming29"><code>@haoming29</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2041">spf13/cobra#2041</a></li> </ul> <hr /> <p>Thank you everyone who contributed to this release and all your hard work! Cobra and this community would never be possible without all of you!!!! 🐍</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/spf13/cobra/compare/v1.7.0...v1.8.0">https://github.com/spf13/cobra/compare/v1.7.0...v1.8.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/spf13/cobra/commit/a0a6ae020bb3899ff0276067863e50523f897370"><code>a0a6ae0</code></a> Improve API to get flag completion function (<a href="https://redirect.github.com/spf13/cobra/issues/2063">#2063</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/890302a35f578311404a462b3cdd404f34db3720"><code>890302a</code></a> Support usage as plugin for tools like kubectl (<a href="https://redirect.github.com/spf13/cobra/issues/2018">#2018</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/48cea5c87b5299b68c3f5b7f2c67ea948717276f"><code>48cea5c</code></a> build(deps): bump actions/checkout from 3 to 4 (<a href="https://redirect.github.com/spf13/cobra/issues/2028">#2028</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/22953d88453ec9343b4a78b9d67400a3326f3138"><code>22953d8</code></a> Replace all non-alphanumerics in active help env var program prefix (<a href="https://redirect.github.com/spf13/cobra/issues/1940">#1940</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/00b68a1c260eaf2b9bcb10a3178d36cec81548ca"><code>00b68a1</code></a> Add tests for flag completion registration (<a href="https://redirect.github.com/spf13/cobra/issues/2053">#2053</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/b711e8760b73c6aa1b4aa1bef3a26da5926f175d"><code>b711e87</code></a> Don't complete --help flag when flag parsing disabled (<a href="https://redirect.github.com/spf13/cobra/issues/2061">#2061</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/8b1eba47616566fc4d258a93da48d5d8741865f0"><code>8b1eba4</code></a> Fix linter errors (<a href="https://redirect.github.com/spf13/cobra/issues/2052">#2052</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/4cafa37bc4bb85633b4245aa118280fe5a9edcd5"><code>4cafa37</code></a> Allow running persistent run hooks of all parents (<a href="https://redirect.github.com/spf13/cobra/issues/2044">#2044</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/5c962a221e70fd6b12296e5d7075f28b422f98b2"><code>5c962a2</code></a> build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.2 to 2.0.3 (<a href="https://redirect.github.com/spf13/cobra/issues/2047">#2047</a>)</li> <li><a href="https://github.com/spf13/cobra/commit/efe8fa3e4453e41d6419b26c9769a51e42825632"><code>efe8fa3</code></a> build(deps): bump actions/setup-go from 3 to 4 (<a href="https://redirect.github.com/spf13/cobra/issues/1934">#1934</a>)</li> <li>Additional commits viewable in <a href="https://github.com/spf13/cobra/compare/v1.7.0...v1.8.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @rigelrozanski in #2565
Ref: #2565 (comment)
queriable.gouseserr2/errResfor theerrorreturn values. For consistency let's use onlyerreverywhereThe text was updated successfully, but these errors were encountered: