Convert Tendermint Block Response

[jbibla]

Summary of Bug

these endpoints should return the proposer_address in bech32 format according to the swagger docs. this would be ideal for client developers.

block/{height}
block/latest

{
  "block_meta": {
      "proposer_address": "cosmos1depk54cuajgkzea6zpgkq36tnjwdzv4afc3d27"

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Thanks @jbibla!

[alexanderbez]

The latest develop, 7f74b33e, returns the proper addresses as raw hex, not bech32 encoded. So nothing to change afaik?

[jbibla]

@alexanderbez sorry for the confusion: can it please return the proposer_address as a bech32 encoded address?

[alexanderbez]

Sure I think we can accommodate that. But won't be it be somewhat weird? It'll be the only value not in raw HEX.

[jbibla]

@cosmos/cosmos-ui how do you feel about this idea?

[faboweb]

I thought we agreed that every consumer/client facing address is in bech32 format?

[alexanderbez]

Actually this seems to be a Tendermint response. I'm not sure we can modify this w/o converting the response to a new structure.

[faboweb]

Let's convert it to a new structure. The REST API should provide a better experience then just forwarding Tendermint messages imo.

[jbibla]

i agree with @faboweb here - we could use the RPC for raw HEXs but we'd prefer to use the REST API.

[alexanderbez]

Being that that this is an TM RPC call, what actionable items are you asking for here?

[faboweb]

We should process the TM RPC call in the REST server endpoint, convert the response into a new struct which fulfills the requirements of the REST server (convert HEX addresses to bech32).

There will also be more conversions for the block response necessary. I.e. the transactions in the block object need to be converted to either links to the actual transactions or resolved into the actual transaction objects. Currently transactions are in base64 format as far as I remember.

[fedekunze]

does this issue still apply?

[jbibla]

@faboweb

[faboweb]

I think this still applies

[alexanderbez]

Yes, we're still returning the raw response from Tendermint. We'll have to intercept this response and convert it to a new type that converts all the addresses (not just the proposer). Also note, the validator address is cosmosvalcons...

[RiccardoM]

Guys if you want I can start working on this issue as I think it might be useful. Could you please point me in the right direction to do so? How should I intercept the response?

@alexanderbez @faboweb

[alexanderbez]

Yes @RiccardoM. Take a look at client/rpc/block.go. In there we call a private function getBlock. You'll have to parse and modify the response.

[tnachen]

@RiccardoM are you still planning to work on this?

[RiccardoM]

@tnachen Yup, I've started working on it but I stopped due to other priorities. I will start working on it again in the next days

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tac0turtle]

we have an endpoint to convert txs into sdk txs for a block, we should be able to add proposer here as well

[amaury1093]

@atheeshp will be looking into this