Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special handlers which can be run during CheckTx (to call isCheckTx) #518

Closed
ebuchman opened this issue Feb 28, 2018 · 3 comments
Closed

Special handlers which can be run during CheckTx (to call isCheckTx) #518

ebuchman opened this issue Feb 28, 2018 · 3 comments

Comments

@ebuchman
Copy link
Member

ebuchman commented Feb 28, 2018 •
edited
Loading

As of #510, handlers run on CheckTx, but don't distinguish between chectx/delivertx.

According to https://github.com/tendermint/abci/blob/master/types/types.proto, the only difference between them is that CheckTx returns a fee and DeliverTx returns the gas_used.

How the SDK distinguishes Check/Deliver and how the fees/gas work needs to be documented and implemented (ie. part of #459)
This was referenced Feb 28, 2018
Closed
Merged
Closed
@rigelrozanski
Copy link
Contributor

Awesome yeah and this needs to be clearly expressed in the basecoin example custom module types.. Working through this exact issue in gaia right now

@cwgoes cwgoes added this to the 1.0 Code Freeze milestone Apr 27, 2018
@davekaj davekaj mentioned this issue Jun 8, 2018
Closed
@rigelrozanski
Copy link
Contributor

As per recent discussions - by default, sdk modules should NOT be run for check tx (beyond fees being deducted) - in the future we will create a special way to register routes which (against the default) do run in checkTx - for these kinds of routes those special handlers will need to reference ctx.IsCheckTx

@rigelrozanski rigelrozanski changed the title Handlers must check isCheckTx Special handlers which can be run during CheckTx (to call isCheckTx) Jun 8, 2018
@ebuchman
Copy link
Member Author

ebuchman commented Jul 6, 2018

Will close this. CheckTx will not run handlers

@ebuchman ebuchman closed this as completed Jul 6, 2018
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@dependabot-preview @fedekunze
Bump github.com/cosmos/cosmos-sdk from 0.40.0-rc6 to 0.40.0-rc7 (cosm…
59273fe 
…os#518)

* Bump github.com/cosmos/cosmos-sdk from 0.40.0-rc6 to 0.40.0-rc7

Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.40.0-rc6 to 0.40.0-rc7.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/master/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.40.0-rc6...v0.40.0-rc7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* go.sum

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sunnya97 @ebuchman @rigelrozanski @cwgoes