Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge x/supply into x/bank #5913

Closed
2 of 4 tasks
alexanderbez opened this issue Apr 2, 2020 · 2 comments · Fixed by #6010
Closed
2 of 4 tasks

Merge x/supply into x/bank #5913

alexanderbez opened this issue Apr 2, 2020 · 2 comments · Fixed by #6010
Assignees
@alexanderbez
Labels
C:x/bank T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: State Machine Breaking State machine breaking changes (impacts consensus).
Milestone
v0.40 [Stargate]

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Apr 2, 2020 •
edited
Loading

Summary

Balances have been separated from x/auth and are managed separately via x/bank.

Problem Definition & Proposal

Given the above changes have been made, it really does not make sense to keep x/supply as a standalone module, but rather merge its functionality into x/bank since all of its APIs are essentially x/bank APIs.

/cc @fedekunze @aaronc

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze fedekunze added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). genesis-breaking T: State Machine Breaking State machine breaking changes (impacts consensus). labels Apr 2, 2020
@fedekunze
Copy link
Collaborator

that's okwme. ModuleAccounts will be moved to auth I assume?

@alexanderbez
Copy link
Contributor Author

Yeah I believe so.

@alexanderbez alexanderbez self-assigned this Apr 16, 2020
@alexanderbez alexanderbez mentioned this issue Apr 16, 2020
Merged
11 tasks
@clevinson clevinson added this to the v0.39 milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:x/bank T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
v0.40 [Stargate]
Development

Successfully merging a pull request may close this issue.

Merge x/supply into x/bank cosmos/cosmos-sdk
3 participants
@clevinson @alexanderbez @fedekunze