Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge x/supply into x/bank #6010

Merged
merged 29 commits into from
Apr 20, 2020
Merged

Merge x/supply into x/bank #6010

merged 29 commits into from
Apr 20, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 16, 2020

Description

  • Merge x/supply into x/bank
  • Module accounts should most likely now live in x/auth, but that should be completed in a follow up PR.

As for reviewing this PR, no critical business logic or state-machine changes were made. Types and APIs were simply moved.

closes: #5913


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: State Machine Breaking State machine breaking changes (impacts consensus). C:x/bank x/supply labels Apr 16, 2020
@alexanderbez alexanderbez self-assigned this Apr 16, 2020
@alexanderbez alexanderbez marked this pull request as ready for review April 17, 2020 18:55
@alexanderbez alexanderbez requested a review from alessio as a code owner April 17, 2020 18:55
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/bank/simulation/decoder.go Show resolved Hide resolved
@jgimeno
Copy link
Contributor

jgimeno commented Apr 20, 2020

utACK

@alexanderbez alexanderbez mentioned this pull request Apr 20, 2020
4 tasks
@alexanderbez alexanderbez merged commit 1083fa9 into master Apr 20, 2020
@alexanderbez alexanderbez deleted the bez/5913-remove-supply-mod branch April 20, 2020 15:22
@clevinson clevinson added this to the v0.39 milestone May 5, 2020
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/bank T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge x/supply into x/bank
6 participants