Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Transaction Simulation Service #5922

Closed
1 of 2 tasks
aaronc opened this issue Apr 3, 2020 · 3 comments · Fixed by #7035
Closed
1 of 2 tasks

gRPC Transaction Simulation Service #5922

aaronc opened this issue Apr 3, 2020 · 3 comments · Fixed by #7035
Assignees

Comments

@aaronc
Copy link
Member

aaronc commented Apr 3, 2020

Summary

As discussed in #5894 (comment), we need an approach for REST/gRPC-based transaction generation to either upgrade or replace the existing REST tx routes. The approach adopted here is to provide a gRPC tx simulation service (see #5922 (comment))

@clevinson clevinson added this to the v0.39 milestone Apr 30, 2020
@fedekunze fedekunze added the REST label May 10, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@aaronc
Copy link
Member Author

aaronc commented Aug 7, 2020

I started working on a protobuf service definition for this. Initially, I started by just copying the current transaction generation BaseReq and creating a service that took a BaseReq and some Msgs and does basically what the existing REST endpoints do.

In discussing with my team, I am rethinking this altogether.

My assessment is that REST transaction generation is basically an anti-pattern. Clients now have the full protobuf Tx schema and should have no problem constructing a Tx. What they need is basically simulation.

Signing transaction content returned from a possibly untrusted service should be avoided at all costs. Maybe the current REST tx endpoints were needed given the situation with amino. But all of the users I talked with when designing the current Tx understood the dangers of signing untrusted content. So I don't feel there is actually a huge benefit to adding this functionality and actually some downsides in that it adds something that could be used to exploit less savvy users.

I propose instead that we create a simple gRPC service for Tx simulation and gas/fee estimation. As I understand it, this should satisfy the core need.

How does this sound as an alternative?

@alexanderbez
Copy link
Contributor

ACK from me @aaronc -- less work as well 👍

@aaronc aaronc changed the title REST/gRPC protobuf transaction generation gRPC Transaction Simulation Service Aug 11, 2020
@amaury1093 amaury1093 self-assigned this Aug 13, 2020
@mergify mergify bot closed this as completed in #7035 Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants