Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - wrong query params on governance votes querier #7588

Closed
yun-yeo opened this issue Oct 19, 2020 · 0 comments · Fixed by #7589
Closed

Bug - wrong query params on governance votes querier #7588

yun-yeo opened this issue Oct 19, 2020 · 0 comments · Fixed by #7589

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Oct 19, 2020

params := types.NewQueryProposalVotesParams(proposalID, page, limit)
bz, err := clientCtx.LegacyAmino.MarshalJSON(params)
if rest.CheckBadRequestError(w, err) {
return
}
res, _, err := clientCtx.QueryWithData("custom/gov/proposal", bz)
if rest.CheckInternalServerError(w, err) {
return
}

Must put proposal query params, not votes query params.

@mergify mergify bot closed this as completed in #7589 Oct 20, 2020
alessio pushed a commit that referenced this issue Oct 23, 2020
From: #7589
Closes: #7588
Thanks: @YunSuk-Yeo 

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant