Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapper.GetPubKeys silently ignore unpacked keys #8129

Closed
4 tasks
robert-zaremba opened this issue Dec 10, 2020 · 0 comments · Fixed by #8828
Closed
4 tasks

wrapper.GetPubKeys silently ignore unpacked keys #8129

robert-zaremba opened this issue Dec 10, 2020 · 0 comments · Fixed by #8828
Assignees
@robert-zaremba
Labels
C:x/auth T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:Bug
Milestone
v0.43

Comments

@robert-zaremba
Copy link
Collaborator

Summary of an Issue

wrapper is a structure which provides TxBuilder functionality. One of the interface methods is GetPubKeys. There is a dangerous, undocumented behavior. wrapper stores signers public keys in a Any structure to support proto marshaling.
We must make sure that whenever we add keys to the wrapper, they should be unpacked, otherwise this can lead to an difficult to catch issues.

Version: v0.40

Proposal

wrapper.GetPubKeys should return internal error.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added T:Bug T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). C:x/auth ice-box labels Dec 10, 2020
@robert-zaremba robert-zaremba added this to the v0.40.1 milestone Dec 10, 2020
@robert-zaremba robert-zaremba mentioned this issue Dec 10, 2020
Open
11 tasks
@clevinson clevinson added backlog and removed ice-box labels Jan 6, 2021
@clevinson clevinson modified the milestones: v0.40.1, v0.41 Jan 8, 2021
@robert-zaremba robert-zaremba mentioned this issue Mar 9, 2021
Merged
9 tasks
alessio pushed a commit that referenced this issue Mar 10, 2021
@robert-zaremba
update SigVerifiableTx.GetPubKeys to return an error (#8828)
8f7cdaf 
closes: #8129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

Labels
C:x/auth T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:Bug
Projects
None yet
Milestone
v0.43
Development

Successfully merging a pull request may close this issue.

update SigVerifiableTx.GetPubKeys to return an error cosmos/cosmos-sdk
3 participants
@aaronc @robert-zaremba @clevinson