Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non consistent form of withdraw reward json key(value) #8581

Closed
4 tasks
carameleon opened this issue Feb 15, 2021 · 0 comments · Fixed by #9599
Closed
4 tasks

non consistent form of withdraw reward json key(value) #8581

carameleon opened this issue Feb 15, 2021 · 0 comments · Fixed by #9599
Assignees
Milestone

Comments

@carameleon
Copy link

carameleon commented Feb 15, 2021

Summary of Bug

When we set validator commission to 100%,
the logs in tx-response have been omitted their value

"key":"amount" has no their value key

commission set 100% (omission value) (tx hash = 0427ADA778454592A5D6ED0CDC1BEA0693E859EC9951FE376138A4936DC03238)

{
  "type": "withdraw_rewards",
  "attributes": [
    {
      "key": "amount"
    },
    {
      "key": "validator",
      "value": "cosmosvaloper1x5wgh6vwye60wv3dtshs9dmqggwfx2ldk5cvqu"
    }
  ]
}

when commission set under 100% (tx hash = A5C34733E253F805466956EE315D8FA9F4D6FB859A9A0C5360A0D1A99A9BFC98)

{
  "type": "withdraw_rewards",
  "attributes": [
    {
      "key": "amount",
      "value": "89007507977umuon"
    },
    {
      "key": "validator",
      "value": "cosmosvaloper1tflk30mq5vgqjdly92kkhhq3raev2hnz6eete3"
    }
  ]
}

I thought it should return the consistent form of tx.

Version

stargate-final, cosmos-sdk 0.41.0

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@clevinson clevinson modified the milestones: Feature Backlog, v0.42.X Jun 25, 2021
@technicallyty technicallyty self-assigned this Jun 26, 2021
@mergify mergify bot closed this as completed in #9599 Jul 5, 2021
mergify bot pushed a commit that referenced this issue Jul 5, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Rewards values of 0 were omitted from the `WithdrawRewards` event.  To provide consistency in event responses, this is caught in the keeper and emitted as a value of  `0[baseDenom]`.

Closes: #8581 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants