Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Generation Errors #872

Closed
rigelrozanski opened this issue Apr 16, 2018 · 3 comments
Closed

Key Generation Errors #872

rigelrozanski opened this issue Apr 16, 2018 · 3 comments
Assignees
@jessysaurusrex

Comments

@rigelrozanski
Copy link
Contributor

Thought this issue may have already been created (@mossid ) but yeah all generated keys end with Abandon - also I noticed that sometimes keys are generated with less than 32 bytes?
@martindale martindale added this to the 1.0 Code Freeze milestone Apr 24, 2018
@cwgoes cwgoes modified the milestone: 1.0 Code Freeze Apr 27, 2018
@ebuchman ebuchman mentioned this issue May 8, 2018
Closed
@ValarDragon
Copy link
Contributor

The solution to this is on tendermint/go-crypto#116. Is it fine to close this issue, since it seems that we're moving away from the current codebase for generating recovery keys?

@liamsi liamsi mentioned this issue Jun 11, 2018
Merged
@rigelrozanski
Copy link
Contributor Author

hmmm I'm in favour of leaving this issue open until it is fixed on the sdk

@ValarDragon
Copy link
Contributor

Closed by #931

ValarDragon added a commit that referenced this issue Jul 10, 2018
@ValarDragon
changelog: Reorder items in the changelog
39fa70b 
Additionally I've added the following entries:

* Added MinInt and MinUint functions

     * The keys sub-module is now in the sdk

* [keys] New keys now have 24 word recovery keys, for heightened security

* \#872  - recovery phrases no longer all end in `abandon`
@ValarDragon ValarDragon mentioned this issue Jul 10, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessysaurusrex jessysaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@zmanian @martindale @jessysaurusrex @ValarDragon @rigelrozanski @cwgoes