Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/staking/keeper: write more tests and also benchmarks #8744

Closed
2 of 4 tasks
odeke-em opened this issue Mar 2, 2021 · 2 comments
Closed
2 of 4 tasks

x/staking/keeper: write more tests and also benchmarks #8744

odeke-em opened this issue Mar 2, 2021 · 2 comments
Labels
T: Performance Performance improvements T: Tests

Comments

@odeke-em
Copy link
Collaborator

odeke-em commented Mar 2, 2021

Summary of Bug

The current test coverage for this package is at 69.5%, but there are critical elements that are untested like
Screen Shot 2021-03-01 at 10 09 16 PM which will help exorcise what could be improved. We also need benchmarks

Version

The latest tip at 010eeef

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@odeke-em odeke-em added T: Tests T: Performance Performance improvements labels Mar 2, 2021
odeke-em added a commit that referenced this issue Mar 2, 2021
@odeke-em
x/staking: add ValidateGenesis benchmark
c69db4c 
This benchmark examines how ValidateGenesis behaves.
In a follow-up issue, I'll show how it reveals an inefficiency
that'll affect trying to load repeatedly retrieve Validators'
ConsAddress values.

Updates #8744
@odeke-em odeke-em mentioned this issue Mar 2, 2021
Merged
9 tasks
odeke-em added a commit that referenced this issue Mar 2, 2021
@odeke-em
x/staking: add ValidateGenesis benchmark (#8746)
585ffd6 
This benchmark examines how ValidateGenesis behaves.
In a follow-up issue, I'll show how it reveals an inefficiency
that'll affect trying to load repeatedly retrieve Validators'
ConsAddress values.

Updates #8744
@github-actions github-actions bot added the stale label Aug 9, 2021
This was referenced Apr 13, 2023
Open
Open
Open
@elias-orijtech
Copy link
Contributor

Gentle ping. Still relevant?

@alexanderbez
Copy link
Contributor

More tests, especially for this package can't hurt. Granted, the module is overdue for a massive cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: Performance Performance improvements T: Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@robert-zaremba @odeke-em @alexanderbez @tac0turtle @elias-orijtech