Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI proto-breaking check on release/* branches #8907

Closed
4 tasks
amaury1093 opened this issue Mar 17, 2021 · 4 comments · Fixed by agoric-labs/cosmos-sdk#138
Closed
4 tasks

Fix CI proto-breaking check on release/* branches #8907

amaury1093 opened this issue Mar 17, 2021 · 4 comments · Fixed by agoric-labs/cosmos-sdk#138
Assignees
@tac0turtle
Labels
T: CI tooling dev tooling within the sdk

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Mar 17, 2021 •
edited
Loading

Summary of Bug

The proto check-breakage CI check doesn't work well on release/* branches.

Version

0836361

Steps to Reproduce

When backporting PRs from master to release/* branches, this check spits non-relevant errors.

An example is https://github.com/cosmos/cosmos-sdk/pull/8883/checks?check_run_id=2128071320#step:3:26:

<input>:1:1:Previously present file "cosmos/authz/v1beta1/authz.proto" was deleted.

Is it comparing to the master branch? Or is it some other bug?

For the time being, I propose to disable the check on release/* branches (keep on master though) Done.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added T: CI tooling dev tooling within the sdk labels Mar 17, 2021
@amaury1093 amaury1093 mentioned this issue Mar 17, 2021
Merged
@aaronc aaronc self-assigned this Mar 17, 2021
@aaronc
Copy link
Member

aaronc commented Mar 17, 2021

Disabled. Sorry about that. I think the issue is buf checking breakage against master. Do you think we maybe setup buf to check against the release branch based on the branch CI is running against @AmauryM ?

@aaronc aaronc closed this as completed Mar 17, 2021
@amaury1093 amaury1093 changed the title Fix or Disable CI proto-breaking check on release/* branches Fix CI proto-breaking check on release/* branches Mar 17, 2021
@amaury1093
Copy link
Contributor Author

Do you think we maybe setup buf to check against the release branch based on the branch CI is running against @AmauryM ?

Yeah I think it would be useful, to avoid unexpected backports.

I re-opened and renamed the issue.

@amaury1093 amaury1093 reopened this Mar 17, 2021
@github-actions github-actions bot added the stale label Jul 31, 2021
@github-actions github-actions bot closed this as completed Aug 6, 2021
@amaury1093 amaury1093 reopened this Aug 6, 2021
@amaury1093 amaury1093 added pinned and removed stale labels Aug 6, 2021
@JimLarson JimLarson mentioned this issue Nov 4, 2021
Merged
19 tasks
@JimLarson
Copy link
Contributor

I think I've got a fix for this in agoric-labs#138. I'll upstream it when I get a chance.

@tac0turtle tac0turtle mentioned this issue Jan 31, 2022
Merged
19 tasks
@tac0turtle tac0turtle assigned tac0turtle and unassigned aaronc Jan 31, 2022
@tac0turtle
Copy link
Member

closed in #11071

@JimLarson JimLarson mentioned this issue Feb 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
T: CI tooling dev tooling within the sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make proto-check-breaking work for forks agoric-labs/cosmos-sdk
4 participants
@aaronc @amaury1093 @tac0turtle @JimLarson