Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make proto-check-breaking work for forks #138

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

JimLarson
Copy link

Description

The make proto-check-breaking always checks for incompatible proto changes against the master branch of cosmos/cosmos-sdk, regardless of whether the PR in question is on a fork or release branch.

Changes the workflow to dynamically specify the target repository and branch of the PR, and changes the Makefile to accept these parameters. Outside of CI testing, can specify the parameters on the make command line.

Probably closes cosmos#8907


Author Checklist

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JimLarson JimLarson added the github_actions Pull requests that update Github_actions code label Nov 4, 2021
@JimLarson JimLarson self-assigned this Nov 4, 2021
Copy link
Collaborator

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code Type: Build Type: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI proto-breaking check on release/* branches
2 participants