Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid transaction fee mechanism #8917

Closed
21 tasks
robert-zaremba opened this issue Mar 17, 2021 · 7 comments
Closed
21 tasks

Solid transaction fee mechanism #8917

robert-zaremba opened this issue Mar 17, 2021 · 7 comments

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Mar 17, 2021

Summary

We identified problems with current fee mechanism. More specifically, it's susceptible for spam attack, state bloating or even DOS attacks.

This is a meta issue to list verticals related to solve the main concerns. General discussion about protocol fees: #8224

Gas prices and zero fee problem

  • Decide about short coming solution for zero fee problem. This has to be enforced by a state logic or consensus.
  • Implement a short coming solution for zero fee problem
  • Decide about long term strategy and dynamic fee mechanims
  • ADR for the fee mechanism
  • Implement dynamic fee mechanism

Related:

Gas

Gas charges = how much gas is consumed by a particular operation / message.
Some operations may be underpriced. There are many attack vectors which attack runtime execution or storage bloat. Good example of that are Ethereum Shanghai attacks.

Related:

Multi Denom Gas Price

For IBC transactions, it may be extremely useful if the protocols could accept payments for gas fee with different currencies.

  • RFC for the multi denom gas payments
    • multi-coin deposits, AMM mechanism for currency exchange or simply accept payments in other currencies...
  • ADR for the multi denom gas payments
  • Implement mutli denom gas payments

Check Transaction fees and spam prevention

A block proposer may not obey CheckTx and spam block with invalid transactions. Such kind of events could pollute a state without much cost. This can be prevented by adding additional fees or some slashable evidence.

@tac0turtle
Copy link
Member

Diving into the fee issue, I dont think the problem is what lives in the sdk, but more so, how to use modular antehandlers and different fee designs is not documented. Looking at the antehandler, in order to write my own fee system I only have to write up to 3 functions. If we were to document how to write custom antehandlers and what different things do, people would be able to write their own systems.

@ethanfrey
Copy link
Contributor

Diving into the fee issue, I dont think the problem is what lives in the sdk, but more so, how to use modular antehandlers and different fee designs is not documented. Looking at the antehandler, in order to write my own fee system I only have to write up to 3 functions. If we were to document how to write custom antehandlers and what different things do, people would be able to write their own systems.

I agree with this. And a simple but usage example will inspire chains to take that and customize as needed. That will scratch lots of itches until a more powerful EIP-1559 solution can be implemented (and give some real world feedback on attack vectors, usability, etc)

@robert-zaremba
Copy link
Collaborator Author

Well, I still think it will be worth to add a reference implementation for the min gas price. I didn't look at the code how the min gas price is set, but probably it goes through sdk.Context.

@alexanderbez
Copy link
Contributor

I have no idea what this issue is proposing...seems like a hodge-podge of random things related to gas and fees...

@robert-zaremba
Copy link
Collaborator Author

This is a meta issue, collecting fee & gas related tasks and ideas. meta-issue label was originally here.

@alexanderbez
Copy link
Contributor

Create a discussion please @robert-zaremba -- let's keep issues to concrete proposals.

@robert-zaremba
Copy link
Collaborator Author

Create a discussion please @robert-zaremba -- let's keep issues to concrete proposals.

The issue is old. That was the way how we were aggregating epics back in time.
This is not really a discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@robert-zaremba @alexanderbez @ethanfrey @tac0turtle and others