Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve fee discovery for wallet users #7347

Closed
4 tasks
zmanian opened this issue Sep 18, 2020 · 7 comments
Closed
4 tasks

Solve fee discovery for wallet users #7347

zmanian opened this issue Sep 18, 2020 · 7 comments

Comments

@zmanian
Copy link
Member

zmanian commented Sep 18, 2020

There is currently no mechanism for validators to suggest to wallet developers what transaction fees they are likely to accept.

This leads to wallet devs essentially guessing what fees to attach to transactions and confusion like

https://forum.cosmos.network/t/transaction-fee/3979/2

Ideas:

  • We could add fee info to the validator information on chain
  • Just have an informal norm for a json blob on a validator website
  • advertise this info over the p2p layer.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

As long as there aren't any security concerns, I think simply advertising this via an API endpoint seems like the easiest approach.

@hxrts
Copy link
Contributor

hxrts commented Sep 19, 2020

Hub validators will also need to advertise which denoms they accept, so maybe these should be addressed together?

Quick solution is validators broadcasting off-chain, but an on-chain gas oracle would be quite valuable. This is one of the big EIP-1559 wins, users can deterministically compute the current base fee within one escalation window from past fees.

Alternatively, Dan Finley's EIP-2593 fee model based on Agoric's escalator algorithm looks like it wouldn't benefit much from a validator-reported min fee.

I think the SDK aims to be unopinionated about what fee model chains elect to use, so probably better to use something light weight for now and revisit when competition for transaction ordering heats up.

@alexanderbez
Copy link
Contributor

alexanderbez commented Sep 19, 2020

Min fee already includes denoms.

@hxrts
Copy link
Contributor

hxrts commented Sep 20, 2020

Right, but is that published to the network?

@alexanderbez
Copy link
Contributor

No. Hence my suggestion for adding an API endpoint (#7347 (comment)).

@clevinson
Copy link
Contributor

This should probably be thought about more as we approach support for meta-transactions / multi-denom fees (#9406)

@tac0turtle
Copy link
Member

we added an endpoint for now for the simple case. It was back ported to 0.45 and 0.46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants