Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multisig key info doesn't display threshold nor pubkeys #9056

Closed
4 tasks
fedekunze opened this issue Apr 6, 2021 · 4 comments
Closed
4 tasks

multisig key info doesn't display threshold nor pubkeys #9056

fedekunze opened this issue Apr 6, 2021 · 4 comments
Assignees
Labels
C:Keys Keybase, KMS and HSMs T:Bug
Milestone

Comments

@fedekunze
Copy link
Collaborator

Summary of Bug

when generating a multisig key, the info from keys show/list doesn't display the threshold nor the pubkeys

Version

Gaia v4.2.0

Steps to Reproduce

Generate a multisig by providing the pubkeys and threshold value to keys add
keys show <name>

- name: ethermint_multisig
  type: multi
  address: cosmos124ezy53svellxqs075g69n4f5c0yzcy5slw7xz
  pubkey: cosmospub1ytql0csgqgfzd666axrjzq5skdyx7f8d8tux3n57ur39zycn0dcdkmcld49lttxmsl4erthm0qfzd666axrjzqslw4atelq2zddfagk77hntmc72aupztnqfr9g7ff4mzp8ae5c4pgfzd666axrjzq6r5w6g2qs5jvms9pkf73e9xk9rl4ze2ahev0wvzkxtstqzya4k0u8rj9cv
  mnemonic: ""
  threshold: 0
  pubkeys: []

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze fedekunze added T:Bug C:Keys Keybase, KMS and HSMs labels Apr 6, 2021
@amaury1093
Copy link
Contributor

Side note: Robert's PR (#7447) replaces the pubkey field with the JSON representation of the multisig pubkey, which includes pubkeys and threshold. But that's on master (and 0.43+) only.

So this issue indeed needs a separate fix.

@amaury1093 amaury1093 added this to the v0.42.X milestone Apr 7, 2021
@fedekunze
Copy link
Collaborator Author

cc: @alessio for context

@atheeshp atheeshp self-assigned this Apr 9, 2021
@atheeshp atheeshp mentioned this issue Apr 14, 2021
9 tasks
@amaury1093
Copy link
Contributor

I double checked with @atheeshp, he will create a PR directly on release/v0.42.x since this is fixed on master via #7447

alessio pushed a commit that referenced this issue Apr 16, 2021
@atheeshp
Copy link
Contributor

Addressed this in #9108

@aaronc aaronc removed the backlog label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs T:Bug
Projects
None yet
Development

No branches or pull requests

4 participants