feat: multisig should accept name, not just address #9553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…khita/add-name-for-multisig
…khita/add-name-for-multisig
Codecov Report
@@ Coverage Diff @@
## master #9553 +/- ##
==========================================
- Coverage 60.66% 60.66% -0.01%
==========================================
Files 588 588
Lines 37250 37265 +15
==========================================
+ Hits 22599 22607 +8
- Misses 12707 12714 +7
Partials 1944 1944
|
…khita/add-name-for-multisig
…khita/add-name-for-multisig
…khita/add-name-for-multisig
…khita/add-name-for-multisig
likhita-809
requested review from
robert-zaremba,
amaury1093,
aleem1314,
anilcse,
atheeshp,
blushi,
cyberbono3,
ebuchman and
ruhatch
amaury1093
reviewed
Jun 22, 2021
…khita/add-name-for-multisig
…khita/add-name-for-multisig
…khita/add-name-for-multisig
anilcse
approved these changes
Jun 23, 2021
amaury1093
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
utACK. @likhita-809 did you manually test this? If yes, you can put automerge on.
manually tested. |
…khita/add-name-for-multisig
likhita-809
added
the
A:automerge
This was referenced May 12, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2022
## Description ref: #11362 I did **NOT** review the following folders, as they contain cryptography which I don't think I'm competent enough to give a useful review: - [ ] `crypto/xsalsa20symmetric` (new in v046, ported from TM i think) - [ ] `crypto/keys/secp256k1` (some new stuff in v046 too) Also performed some manual tests as part of #11939: - [x] Create keys on v0.45, make sure they still work in v0.46 #11939 (comment) - [x] Create new keys in v0.46 #11939 (comment) - [x] `--multisig` flag works with an address that's not in the keyring (see [repro](#9553)) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #9407
--multisigshould accept name, not just an addressAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change