-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Testing for v0.46 #11880
Comments
This was referenced Jun 1, 2022
mergify bot
pushed a commit
that referenced
this issue
Jun 3, 2022
## Description It seems like we added `--fee-payer` and `--fee-granter` flags to the CLI, but when generating a tx, they are ignored. ref: #11880 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
mergify bot
pushed a commit
that referenced
this issue
Jun 3, 2022
## Description It seems like we added `--fee-payer` and `--fee-granter` flags to the CLI, but when generating a tx, they are ignored. ref: #11880 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 889dfcb)
19 tasks
I'm closing this issue, everything has been checked (except #12100, tracked separately) 🎉 . Thanks everyone who participated in this manual testing, especially a big shoutout to @likhita-809 @atheeshp and @JeancarloBarrios ! |
Repository owner
moved this from In Progress
to Done
in Cosmos SDK Maintenance
Jun 3, 2022
Repository owner
moved this from 📝 Todo
to 👏 Done
in Cosmos-SDK
Jun 3, 2022
amaury1093
added a commit
that referenced
this issue
Jun 3, 2022
## Description It seems like we added `--fee-payer` and `--fee-granter` flags to the CLI, but when generating a tx, they are ignored. ref: #11880 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 889dfcb) Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue tracks all v0.46 changes we should be manually testing before the final release. Part of #11096.
This list has been compiled by scanning through the changelog.
Manual Test Description
For each task, please write 1-2 lines on which exact commands were tested (or a link to a script), with the following format
Manual tests
Gov/Group
v1
Module Readiness Checklist #11086tx gov submit-proposal <json>
with the new JSON format @JeancarloBarriostx group ...
commands @JeancarloBarriosTransaction Tips
Other
--multisig
flag works with an address that's not in the keyring fix: multisig works with only multisig name as argument, not its address #11197 @AmauryM--ledger
. Send some funds to this account. Perform a in-place migration to v0.46. Make surev046_node keys list
still has the ledger key. On the v046 node, do a bank send from the ledger account, make sure it works.{ "code": 2, "message": "out of range: cannot paginate 0 txs with offset 0 and limit 100: invalid request", "details": [ ] }
is this intended behaviour?tx staking cancel-unbond
feat: Cancel unbonding delegation entry #10885tx bank multi-send
feat: implement multi-send transaction command #11738--split
flag along with this, amount is split equally to the to-addresses otherwise each account gets the specified amount of tokens.start --grpc-only
, make sure we can still do gRPC queries feat: grpc-only mode #11430curl
orgrpcurl
which worksq feegrant grants-by-granter
feat: add feegrant query to see allowances from a given granter #10947grants-by-granter
to get all the grants provided from a single granter to different grantees.q authz grants-by-grantee
feat: add grants by grantee authz query #10944send
) from a granter to a grantee and then query the grants for a grantee usinggrants-by-grantee
cmd which shows the grants provided to itmax-recv-msg-size
andmax-send-msg-size
in app.toml, make sure large gRPC requests are blocked feat!: support custom r/w gRPC options #11889 @likhita-809max-recv-msg-size
andmax-send-msg-size
values to1
. Now start the node and try do any gRPC request (for e.g., cosmos.bank.v1beta1.Query/Balance), it fails with err
grpc: received message larger than max
.tx multi-sign
feat: implement multi-send transaction command #11738 @likhita-809tx multi-sign
andtx multisign
both works, sincemultisign
is now an alias formulti-sign
in auth to be consistent with bank'smulti-send
tendermint inspect
feat: add tm inspect cmd #11548 @JeancarloBarriosconfig/gentx
folder with different msg other thanMsgCreateValidator
(for., e.g,{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgEditValidator","description":{"moniker":"test","identity":"","website":"","security_contact":"","details":""},"min_self_delegation":"1","validator_address":"cosmosvaloper1gjrjd93lhafax6reev72aeq00h699rpw58jvsq"}],"memo":"5b4e5bd4741531b575f53e51bb7e9f32deec8e26@192.168.1.61:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"Ayl0uR3X/3EnfYy1fA3XIssVh+IH9r88sJyG7fJUravU"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["bf9GvJGBngfMBCHdh7k/SRKnfxyHdvlukY7+ar6V4Px86L6J9ZcJOYLLAHgtYcyIT6TMqEAofCo6mvakViTV8A=="]}
)collect-gentxs
cmd, which returns appropriate errunexpected GenTx message type; expected: MsgCreateValidator, got: *types.MsgEditValidator
SpendableBalances
feat: add support for spendable balances gRPC query #11417 @atheeshpMsgCancelUpgrade
feat: AddMsgSoftwareUpgrade
andMsgCancelUpgrade
(for new msgs-based gov proposals) #11116 @likhita-809offline
,generate-only
andchain-id
flags, then the following error is returned :chain ID cannot be used when offline and generate-only flags are set
. If only one of theoffline
orgenerate-only
flags are used withchain-id
, it works./cosmos/params/v1beta1/subspaces
feat: implement x/params get all subspaces/keys #9884 @likhita-809grpcurl -plaintext localhost:9090 cosmos.params.v1beta1.Query/Subspaces
which returns all the subspaces from params.--staking-bond-denom
flag feat: specify staking bond_denom when creating a new chain #9776 @likhita-809staking-bond-denom
flag with some denom value (e.g., my_denom), check the stakingbond_denom
value in genesis file created. It'll have the valuemy_denom
. By default the staking bond_denom value isstake
.DenomOwners
feat: add DenomOwners gRPC method for x/bank #9533 @JeancarloBarrios--generate-only
flag can be used with a keyname from the keyring. When using--offline
and--generate-only
the key names are no longer recognized, have to use an address #9837 @likhita-809generate-only
flag andfrom
flag with value key name which results in successful transaction. Now, we can use both key address and key name forfrom
flag when used withgenerate-only
.fee.{payer,granter}
andtip
fields to StdSignDoc #10348 @AmauryM--fee-{payer,granter}
#12127tx gov submit-legacy-proposal
by passing --upgrade-info <random_value>, it fails. Again test it with passing empty plan info, it fails again. We can also test with incorrect data without checksum, we'll havemissing checksum query parameter
error.MsgCreatePermanentLockedAccount
feat: add msg for permanent locked vesting accounts #11019 @AmauryMsimd tx vesting create-permanent-locked-account cosmos1e0jnq2sun3dzjh8p2xq95kk0expwmd7shwjpfg 10stake --from validator --keyring-backend test --chain-id my-chain --broadcast-mode block
, code 0debug pubkey-raw
feat: Add debug pubkey-raw cli command #11006 @likhita-809debug pubkey-raw
with pubkey of a key. It returned the parsed key's Address, Json(base64), Bech32 Acc, Bech32 Validator Operator and Consensus.grants-by-granter
where grant can be listed. Query again after 10 seconds, the grant is not found since it is expired.grants-by-granter
, where the grant can be listed with expiration time null.--output
flag format (json or text). feat: improve cli tx output #11818 @likhita-809output
flag valuejson
, which returns the o/p in json format. Again run the same cmd without passingoutput
flag, which returns the o/p in YAML format (default format).--fee-granter
works (replaces--fee-account
) fix!: Add--fee-payer
CLI flag, rename--fee-account
to--fee-granter
#10625 @likhita-809feegrant grant
cmd to grant authorization for grantee to pay fees from grantergov submit-proposal
(for e.g., Where proposal file contains a send proposal with from address as gov module account address and to address is grantee address with amount and deposit) withfee-granter
granter address and proposer account. This results in a successful tx.NOTE: Here the
to_address
in proposal file must be grantee since there must be a feegrant from granter to grantee for the transaction to be successful.edit-validator
command's--moniker
flag to--new-moniker
fix: edit validator bug from the cli #10684 @likhita-809--expiration
tx grant
CLI Flag: was now + 1year, update: null (no expire date). feat!: make grant expiration optional #11060 @likhita-809FlagAPI*
flags for the api server feat: api server flags to start command #11511 @likhita-809api.enable
flag and if required, other api flags from the cli. If we try accessing api server, it works.your node may be syncing, please check node status using /status
followed by the actual error.--sequence
and--account-number
flags with default flag values when used withoffline=false
insign-batch
command. fix: overwrite sequence and account-number flags when used with offline=false #9856 @likhita-809generate-only
flag and save the output json's to a file. Then sign it usingsign-batch
tx cmd providingoffline
flag which definitely requiresaccount-number
andsequence
flags with it, otherwise returns an error stating the requirement flags. If tx succeds, it returns an output with given sequence and account number. Again try to sign usingoffline=false
flag value, then it may takesequence
andaccount-number
from cli, but the returned output will havesequence
andaccount-number
starting from default values (for e.g, 0), i.e., ifaccount-number
andsequence
flags are given, they are overridden.submit-legacy-proposal
transaction. fix(cli):submit-legacy-proposal
: return propoer error if no flag is provided #11287 @likhita-809submit-legacy-proposal
tx withtitle
,description
andtype
from a proposal, it succeeds. Again create asubmit-legacy-proposal
tx with one or more of the flags fromtitle
,description
andtype
missing, it returns an err saying that particular missing flag is required.--dry-run
not working when using tx command. fix:--dry-run
not working when using tx command #11558 @likhita-809--dry-run
returns an error #12074bank q total
query. fix: Update query.go to include pagination for bank q totals #11355 @likhita-809q bank total
cmd withpage
flag (for e.g., --page 2) which now returns the queried output.tendermint-validator-set
query command respects the-o
output flag. fix: ensure tendermint-validator-set respects output flag #11065 @likhita-809/cosmos/tx/v1beta1/txs/{hash}
endpoint returns a 404 when a tx does not exist. The/cosmos/tx/v1beta1/txs/{hash}
endpoint should return a 404 error if no tx is found for the given hash #10985 @likhita-809/cosmos/tx/v1beta1/txs/{hash}
endpoint with an invalid hash, it returns tx not found page. When a valid hash is given, it returns the successful tx response.simd q distribution rewards $KEY_ADDRESS $VALIDATOR_ADDRESS
which returns empty rewards.txhash
, where theraw_log
contains{"type":"withdraw_rewards","attributes":[{"key":"amount","value":"0"}
chain-id
flag, then we'll get the chain-id from client config and node gets initialised with that chain-id and provided moniker.q bank total
we'll get the supply output. If any args are passed to it (for e.g.,q bank total arg
), an error is returned.simd tx gov submit-proposal proposal.json --from mykey1 -y
)Error: chain ID required but not specified
--chain-id flag
(ex:simd tx gov submit-proposal proposal.json --chain-id test-chain --from mykey1 -y
)--generate-only
,--max-msgs
fags set while executingWithdrawAllRewards
command. fix:--max-msgs
withgenerate-only
should not throw error #10842 @atheeshp--generate-only
,--max-msgs
, working as epected.--gas auto
when executing CLI transactions in--generate-only
mode fix: ensure TxFactory has acc & seq fields when simulating tx in generate-only mode #11313 @likhita-809--generate-only
and--gas
flag with valueauto
, which returns the proper response now instead of error.show-adress
cli cmd fix(cli): fix theshow-address
cli cmd #11337 @likhita-809tendermint show-address
cmd, which returns the node's tendermint validator consensus address.AllowancesByGranter
query. fix: grants by granter paginationtotal
#11813 @likhita-809tx feegrant grant
cmd to grant authorization to pay fees from granter to grantee. Run this cmd 2 or more times with same granter and different grantees. Now query these grants using grpc (i.e.,curl http://localhost:1317/cosmos/feegrant/v1beta1/issued/{granter}
) where all the grants are returned with correct total count.Skipped
rollback
command (already in v0.45)The text was updated successfully, but these errors were encountered: