Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Testing for v0.46 #11880

Closed
66 of 72 tasks
Tracked by #11096
amaury1093 opened this issue May 5, 2022 · 1 comment
Closed
66 of 72 tasks
Tracked by #11096

Manual Testing for v0.46 #11880

amaury1093 opened this issue May 5, 2022 · 1 comment
Assignees
Labels
T:Epic Epics Type: QA Quality Assurance

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented May 5, 2022

This issue tracks all v0.46 changes we should be manually testing before the final release. Part of #11096.

This list has been compiled by scanning through the changelog.

Manual Test Description

For each task, please write 1-2 lines on which exact commands were tested (or a link to a script), with the following format

// Example:
- [x] `MsgCancelUpgrade` #11116
  - TEST:  On localnet, create a software upgrade proposal, set height to block 100 (set voting period short, e.g. 30s). After proposal passes, submit another proposal `MsgCancelUpgrade`. Make sure upgrade doesn't happen on block 100.

Manual tests

Gov/Group

Transaction Tips

Other

Skipped

@amaury1093 amaury1093 added the Type: QA Quality Assurance label May 5, 2022
@amaury1093 amaury1093 mentioned this issue May 5, 2022
56 tasks
@tac0turtle tac0turtle added the T:Epic Epics label May 8, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 8, 2022
@amaury1093 amaury1093 moved this to In Progress in Cosmos SDK Maintenance May 18, 2022
@amaury1093 amaury1093 self-assigned this May 18, 2022
mergify bot pushed a commit that referenced this issue Jun 3, 2022
## Description

It seems like we added `--fee-payer` and `--fee-granter` flags to the CLI, but when generating a tx, they are ignored.

ref: #11880



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
mergify bot pushed a commit that referenced this issue Jun 3, 2022
## Description

It seems like we added `--fee-payer` and `--fee-granter` flags to the CLI, but when generating a tx, they are ignored.

ref: #11880

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 889dfcb)
@amaury1093
Copy link
Contributor Author

amaury1093 commented Jun 3, 2022

I'm closing this issue, everything has been checked (except #12100, tracked separately) 🎉 .

Thanks everyone who participated in this manual testing, especially a big shoutout to @likhita-809 @atheeshp and @JeancarloBarrios !

Repository owner moved this from In Progress to Done in Cosmos SDK Maintenance Jun 3, 2022
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Jun 3, 2022
amaury1093 added a commit that referenced this issue Jun 3, 2022
## Description

It seems like we added `--fee-payer` and `--fee-granter` flags to the CLI, but when generating a tx, they are ignored.

ref: #11880

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 889dfcb)

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Epic Epics Type: QA Quality Assurance
Projects
Archived in project
Development

No branches or pull requests

2 participants