Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make proto-gen script #9811

Closed
4 tasks
mattverse opened this issue Jul 29, 2021 · 0 comments · Fixed by #9854
Closed
4 tasks

Fix make proto-gen script #9811

mattverse opened this issue Jul 29, 2021 · 0 comments · Fixed by #9854

Comments

@mattverse
Copy link
Contributor

Summary of Bug

When users fork the cosmos-sdk repo and uns the script make proto-gen, it generates a conflict with the initial cosmos-sdk repo that has been ran in the environment. That is, as the make proto-gen command uses the inital volume for docker (-v $(CURDIR):/workspace) , when there are multiple cosmos-sdk repositories cloned in the local environment, the script make proto-gen only works limited to the initial cosmos-sdk repo.

Additional fixes are required in the make proto-gen script to be able to locate the respective volume depending on the directory.

Version

v0.42.7

Steps to Reproduce

  • fork cosmos-sdk in the your repo
  • clone the repo, make a change in any of the proto files, then generate the proto using make proto-gen script.
  • clone a different cosmos-sdk repo, mae a change in any of the proto files, then try generating the proto using make proto-gen script.
  • No changes would happen to the second repo cloned and worked on, since the volume is set to the initial repo cloned.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@gsk967 gsk967 mentioned this issue Aug 5, 2021
Merged
19 tasks
@mergify mergify bot closed this as completed in #9854 Aug 10, 2021
mergify bot pushed a commit that referenced this issue Aug 10, 2021
@gsk967
fix: fix the issue of make proto-gen (#9854)
84cc05b 
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: #9811 
Previously `make proto-gen` used the same container name for all cosmos based sdks, now it will choose container name dynamically based on project name

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix the issue of make proto-gen
1 participant
@mattverse