-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for Check/DeliverTx middlewares #9954
Comments
amaury1093
added
T:Docs
Changes and features related to documentation.
C:baseapp
labels
Aug 17, 2021
19 tasks
This was referenced Mar 10, 2022
Closed
JeancarloBarrios
added a commit
that referenced
this issue
Mar 24, 2022
19 tasks
Repository owner
moved this from In Review
to Done
in Cosmos SDK Maintenance
Apr 3, 2022
mergify bot
pushed a commit
that referenced
this issue
Apr 3, 2022
## Description Closes: #9954 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Re-opening, there are still 2 docs pieces |
19 tasks
Repository owner
moved this from 👀 Needs Review
to 👏 Done
in Cosmos-SDK
May 10, 2022
Repository owner
moved this from In Progress
to Done
in Cosmos SDK Maintenance
May 10, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The Check/DeliverTx middleware refactor changes a bunch of things in baseapp, and docs should reflect that.
Proposal
Update docs with the following items. Inspiration can come from https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-045-check-delivertx-middlewares.md
Go through exising docs, remove mentions of the following outdated items in https://docs.cosmos.network/v0.44/core/baseapp.html
Add a new page in Core Concepts called "CheckTx and DeliverTx middlewares" docs: added middleware documentation (#9954) #11445
Add new page in the
Migrations
subsection for migration docs Antehandlers -> MiddlewaresFor Admin Use
The text was updated successfully, but these errors were encountered: