Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Check/DeliverTx middlewares #9954

Closed
2 of 7 tasks
Tracked by #11096
amaury1093 opened this issue Aug 17, 2021 · 1 comment · Fixed by #11445 or #11918
Closed
2 of 7 tasks
Tracked by #11096

Update docs for Check/DeliverTx middlewares #9954

amaury1093 opened this issue Aug 17, 2021 · 1 comment · Fixed by #11445 or #11918
Assignees
Labels
C:baseapp T:Docs Changes and features related to documentation.

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Aug 17, 2021

Summary

The Check/DeliverTx middleware refactor changes a bunch of things in baseapp, and docs should reflect that.

Proposal

Update docs with the following items. Inspiration can come from https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-045-check-delivertx-middlewares.md


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added T:Docs Changes and features related to documentation. C:baseapp labels Aug 17, 2021
@amaury1093 amaury1093 moved this from Icebox to Ready in Cosmos SDK Maintenance Mar 10, 2022
This was referenced Mar 10, 2022
@amaury1093 amaury1093 moved this from Ready to In Progress in Cosmos SDK Maintenance Mar 17, 2022
@amaury1093 amaury1093 moved this from In Progress to In Review in Cosmos SDK Maintenance Mar 30, 2022
@mergify mergify bot closed this as completed in #11445 Apr 3, 2022
Repository owner moved this from In Review to Done in Cosmos SDK Maintenance Apr 3, 2022
mergify bot pushed a commit that referenced this issue Apr 3, 2022
## Description

Closes: #9954



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@amaury1093 amaury1093 reopened this Apr 6, 2022
@amaury1093
Copy link
Contributor Author

Re-opening, there are still 2 docs pieces

@amaury1093 amaury1093 moved this from Done to Ready in Cosmos SDK Maintenance Apr 8, 2022
@julienrbrt julienrbrt moved this from Ready to In Progress in Cosmos SDK Maintenance Apr 11, 2022
@julienrbrt julienrbrt moved this to In Progress in Cosmos-SDK May 6, 2022
@julienrbrt julienrbrt moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK May 10, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK May 10, 2022
Repository owner moved this from In Progress to Done in Cosmos SDK Maintenance May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:baseapp T:Docs Changes and features related to documentation.
Projects
Archived in project
Archived in project
3 participants