Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump TM to v0.35.0 release candidate #10210

Merged
merged 126 commits into from
Nov 16, 2021
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 21, 2021

also closes #8986


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez added the dependencies Pull requests that update a dependency file label Sep 21, 2021
@orijbot
Copy link

orijbot commented Sep 21, 2021

go.mod Outdated Show resolved Hide resolved
@alexanderbez alexanderbez marked this pull request as ready for review September 22, 2021 14:41
@alexanderbez alexanderbez marked this pull request as draft September 22, 2021 14:48
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-Approving to unblock work (and avoid merge conflicts every other day). Would love to get the couple last nits addresses though.

I think it's worth creating an issue to bump cosmos.base.tendermint.v1beta1. There's also some desire to do so from #10496

@creachadair
Copy link
Contributor

Pre-Approving to unblock work (and avoid merge conflicts every other day). Would love to get the couple last nits addresses though.

I think it's worth creating an issue to bump cosmos.base.tendermint.v1beta1. There's also some desire to do so from #10496

Per your request, I filed #10558. I don't have enough context to write a useful issue for the latter, so I'll leave that to one of the SDK maintainers.

@amaury1093
Copy link
Contributor

amaury1093 commented Nov 16, 2021

Thanks! Good to go 👍

Per your request, I filed #10558. I don't have enough context to write a useful issue for the latter, so I'll leave that to one of the SDK maintainers.

#10560

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 16, 2021
@creachadair creachadair removed the A:automerge Automatically merge PR once all prerequisites pass. label Nov 16, 2021
@creachadair
Copy link
Contributor

I have removed automerge here, because the default squash commit log will be unreadable. I'll monitor the testing and merge if/when it succeeds.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #10210 (c6b34db) into master (3184cfc) will decrease coverage by 0.26%.
The diff coverage is 67.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10210      +/-   ##
==========================================
- Coverage   65.15%   64.88%   -0.27%     
==========================================
  Files         608      608              
  Lines       58022    57850     -172     
==========================================
- Hits        37802    37537     -265     
- Misses      18107    18199      +92     
- Partials     2113     2114       +1     
Impacted Files Coverage Δ
baseapp/abci.go 60.25% <ø> (+0.29%) ⬆️
client/utils.go 48.88% <0.00%> (ø)
x/auth/middleware/basic.go 65.34% <ø> (ø)
x/auth/migrations/legacytx/stdtx.go 81.41% <0.00%> (-0.73%) ⬇️
x/feegrant/client/testutil/suite.go 99.61% <ø> (-0.01%) ⬇️
x/params/types/consensus_params.go 0.00% <0.00%> (ø)
x/simulation/params.go 31.88% <0.00%> (ø)
simapp/test_helpers.go 26.72% <25.00%> (ø)
server/config/toml.go 66.66% <33.33%> (-9.34%) ⬇️
store/v2/flat/store.go 90.84% <33.33%> (ø)
... and 55 more

@creachadair creachadair merged commit af8ad3d into master Nov 16, 2021
@creachadair creachadair deleted the bez/bump-tm-v0.35.x branch November 16, 2021 19:24
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
Separated out the db dependency changes from: cosmos#10210.

Might need to wait till after cosmos#10210 is merged


---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
Extracted from cosmos#10210.

Make the test more reproducible, so that it does not require coordination
between the build container and the run container.

- Use layers to more advantage.
- Include bash in the run container.
- Put writable output onto a volume.
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
Integrate Tendermint v0.35.0, including changes to build and test
plumbing necessary to make everything build. This change does not
update any SDK APIs to make use of new features.

Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: tycho garen <garen@tychoish.com>
Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
@blushi blushi mentioned this pull request May 13, 2022
19 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Integrate Tendermint v0.35.0, including changes to build and test
plumbing necessary to make everything build. This change does not
update any SDK APIs to make use of new features.

Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: tycho garen <garen@tychoish.com>
Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
…0551) (cosmos#10552)

* build: fix build environment for the liveness test (cosmos#10551)

Extracted from cosmos#10210.

Make the test more reproducible, so that it does not require coordination
between the build container and the run container.

- Use layers to more advantage.
- Include bash in the run container.
- Put writable output onto a volume.

(cherry picked from commit 70a3a90)

# Conflicts:
#	Makefile

* fix conflict

Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP client on the websocket endpoint
10 participants