fix: issue #10258 related to segmentaiton fault on mac m1 arm64

[9M6]

Description

Closes: #10258

fixed an issue where the makefile target build-linux would build a faulty binary file on a mac m1, since the compilation target
was AMD64, but it was needed to be ARM64.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[amaury1093]

utACK (just tested on my non-M1 mac, it builds).

Maybe someone with a M1 can test it before merging? cc @frumioj

[9M6]

utACK (just tested on my non-M1 mac, it builds).

Maybe someone with a M1 can test it before merging? cc @frumioj
@AmauryM

Just a heads-up, this PR fixes only the build-linux make target, there's another follow up issue
with the make target localnet-start which for some reason if the image is built as arm64 it wont run.

The solution that I have written works well with the issue above, since when running the localnet-start the image will be built on amd64 arch.

GOARCH=$(if $(findstring aarch64,$(shell uname -m)),arm64,amd64) the function will return ARM64 in case it finds aarch64 which is the case for alpine, but if the build target is run on a M1 it will return AMD64, since MacOS outputs by default arm64 and the make function does not find aarch64.

[frumioj]

If the suggested change is committed, LGTM. Pre-approving.

[frumioj]

Suggested change

	GOOS=linux GOARCH=$(if $(findstring aarch64,$(shell uname -m)),arm64,amd64) LEDGER_ENABLED=false $(MAKE) build
	GOOS=linux GOARCH=$(if $(findstring aarch64,$(shell uname -m)) || $(findstring arm64, $(shell uname -m)),arm64,amd64) LEDGER_ENABLED=false $(MAKE) build

[frumioj]

Because uname -m reports differently on Debian/M1 vs. MacOS/M1:

johnk@debian:~/src/cosmos-sdk$ uname -m
aarch64

MacOS/M1

frumiousj@dirtycomputer cosmos-sdk % uname -m
arm64
frumiousj@dirtycomputer cosmos-sdk % uname
Darwin

[9M6]

This will not work well with localnet-start as I've explained in the comment above, for some reason, in MacOS/M1, when the build GOARCH is set to ARM64, the localnet-start binary (when executed) will output that there's a architecture mismatch.

[frumioj]

utACK (just tested on my non-M1 mac, it builds).
Maybe someone with a M1 can test it before merging? cc @frumioj
@AmauryM

Just a heads-up, this PR fixes only the build-linux make target, there's another follow up issue with the make target localnet-start which for some reason if the image is built as arm64 it wont run.

It won't run because of incompatibility between the image architecture and that of the docker image it's being run in. I did actually find a way to fix that some time ago IIRC, but my branch is still a WIP: regen-network/regen-ledger#410 - perhaps that might be helpful though?

[9M6]

utACK (just tested on my non-M1 mac, it builds).
Maybe someone with a M1 can test it before merging? cc @frumioj
@AmauryM

Just a heads-up, this PR fixes only the build-linux make target, there's another follow up issue with the make target localnet-start which for some reason if the image is built as arm64 it wont run.

It won't run because of incompatibility between the image architecture and that of the docker image it's being run in. I did actually find a way to fix that some time ago IIRC, but my branch is still a WIP: regen-network/regen-ledger#410 - perhaps that might be helpful though?

Will check it out, thank you 😄

[tac0turtle]

what is the status here?

[amaury1093]

Ping. Is it okay to put automerge? We have 2 approvals

[9M6]

Ping. Is it okay to put automerge? We have 2 approvals

I will check if the suggested change from @frumioj breaks anything, since as he pointed out this fix might not work with Debian/M1.

[9M6]

@AmauryM I've tested the changes suggested by @frumioj and its working well on my side.

[tac0turtle]

running make-simd-linux fails for 64 Segmentation fault go mod download.

This also seems to have broken ci livness test

[9M6]

running make-simd-linux fails for 64 Segmentation fault go mod download.

This also seems to have broken ci livness test

What Arch?

[tac0turtle]

this is within the docker container. when you run make build-simd-linux it fails

[9M6]

this is within the docker container. when you run make build-simd-linux it fails

Can you tell me how to replicate?

[webmaster128]

If I am not missing something, this PR introduced a regression (see #12798 (comment))