feat: add cli for tips transactions #10311

atheeshp · 2021-10-06T06:32:13Z

Description

This PR makes 2 changes in the CLI:

1. Add an `--aux` flag to all tx command.

simd tx bank send <from> <to> <amount> --aux (optional: --tip <tipAmt> --tipper <tipper>)

This will print an AuxSignerData instead of broadcasting the tx.

2. Add a new `aux-to-fee` subcommand

simd tx aux-to-fee <aux_signer_data.json>

This takes the output of the previous command, and broadcasts a 2-signer tx.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…iddleware

…to am/middleware

…ps-cli

amaury1093

it's looking pretty good! A couple of last nits

client/flags/flags.go

client/tx/factory.go

client/tx/tx.go

client/tx/tx_test.go

x/auth/client/testutil/suite.go

client/tx/tx.go

…atheesh/tips-cli

…ps-cli

…atheesh/tips-cli

amaury1093

Nice! Last couple of nits.

@atheeshp could you also add a changelog entry?

client/tx/tx_test.go

client/tx/tx.go

x/auth/client/cli/tips.go

x/auth/client/testutil/suite.go

amaury1093

Approving, thanks a lot Atheesh!

Pending changelog entry

amaury1093 · 2021-12-07T10:48:16Z

client/tx/factory.go

+	parsedTips, err := sdk.ParseCoinsNormalized(tip)
+	if err != nil {
+		panic(err)
+	}


@atheeshp if you can find a way to:

move this logic together with the "check tipper not empty" logic

not panic in the CLI

then that would be ideal! If not, then it's okay like this too.

…ps-cli

CHANGELOG.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

i-norden

Weird, I can see in my github history that I reviewed this. But the only comment of mine I see is the one responding to Amaury... In any case, I can't find any remaining issues!

amaury1093 · 2021-12-07T17:53:11Z

thanks for the review @i-norden ! No you didn't dream, I also remember your previous review comments #10311 (comment)

## Description Closes: cosmos#10264 This PR makes 2 changes in the CLI: ### 1. Add an `--aux` flag to all tx command. ```bash simd tx bank send <from> <to> <amount> --aux (optional: --tip <tipAmt> --tipper <tipper>) ``` This will print an AuxSignerData instead of broadcasting the tx. ### 2. Add a new `aux-to-fee` subcommand ```bash simd tx aux-to-fee <aux_signer_data.json> ``` This takes the output of the previous command, and broadcasts a 2-signer tx.  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

amaury1093 and others added 30 commits August 12, 2021 11:24

Replace abci calls with txHandler

48da6e2

still WIP

3e4d7b6

Use inner

096d103

runTx middleware

11bd37f

Fix some tests

c666dc9

Simplify runMsgs

664f8d7

Merge branch 'master' of ssh://github.com/cosmos/cosmos-sdk into am/m…

25a643e

…iddleware

Fix ante event emitting

ac74030

Use context.Context

0b8f940

Small refactor

080c6af

Fix antehandler events

c3911f8

Add Simulate

6582496

Fix gasInfo

a900541

Add gas tx middleware

6b1f9d7

Fix baseapp_test

bbf2872

Fix tests

dd32108

Fix grpc SimulateTx test

60d43dc

Fix slashing test

4451a4b

Merge branch 'master' into am/middleware

7f071da

Fix mock tests

c5c0247

Fix antehandlers test

67a2cd5

Merge branch 'master' into am/middleware

788d7a0

Address reviews

8fee5b9

Merge branch 'am/middleware' of ssh://github.com/cosmos/cosmos-sdk in…

43c4de0

…to am/middleware

More reviews

00fce8c

Fix tests

e5a076f

Merge branch 'master' into am/middleware

dd70e91

Switch ComposeMiddlewares order

61d1013

Fix test

74167e9

Merge branch 'master' into am/middleware

0bb9c48

atheeshp and others added 2 commits December 6, 2021 11:48

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/ti…

091835a

…ps-cli

Merge branch 'master' into atheesh/tips-cli

5c05d4d

amaury1093 reviewed Dec 6, 2021

View reviewed changes

client/tx/tx.go Outdated Show resolved Hide resolved

atheeshp added 9 commits December 6, 2021 15:46

fix test

c217410

Merge branch 'atheesh/tips-cli' of github.com:cosmos/cosmos-sdk into …

9e6481a

…atheesh/tips-cli

fix tests

c6dad76

Merge branch 'atheesh/tips-cli' of github.com:cosmos/cosmos-sdk into …

4d611a6

…atheesh/tips-cli

fix test

66e8e93

fix tests

8d6385e

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/ti…

aa9744d

…ps-cli

Merge branch 'atheesh/tips-cli' of github.com:cosmos/cosmos-sdk into …

0197e81

…atheesh/tips-cli

fix tests

28e6deb

atheeshp requested a review from amaury1093 December 7, 2021 06:09

amaury1093 reviewed Dec 7, 2021

View reviewed changes

review changes

ecaf012

amaury1093 approved these changes Dec 7, 2021

View reviewed changes

atheeshp added 2 commits December 7, 2021 17:14

add changelog

7747f53

Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/ti…

771870d

…ps-cli

amaury1093 reviewed Dec 7, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

39c20d4

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

i-norden approved these changes Dec 7, 2021

View reviewed changes

Merge branch 'master' into atheesh/tips-cli

9b3faa9

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Dec 7, 2021

mergify bot merged commit 5f840be into master Dec 7, 2021

mergify bot deleted the atheesh/tips-cli branch December 7, 2021 18:02

gamarin2 mentioned this pull request Dec 17, 2021

Metatransactions backend functionality EmerisHQ/demeris-backend#350

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add cli for tips transactions #10311

feat: add cli for tips transactions #10311

atheeshp commented Oct 6, 2021 •

edited by amaury1093

Loading

amaury1093 left a comment

amaury1093 left a comment

amaury1093 left a comment

amaury1093 Dec 7, 2021 •

edited

Loading

i-norden left a comment

amaury1093 commented Dec 7, 2021

feat: add cli for tips transactions #10311

feat: add cli for tips transactions #10311

Conversation

atheeshp commented Oct 6, 2021 • edited by amaury1093 Loading

Description

1. Add an --aux flag to all tx command.

2. Add a new aux-to-fee subcommand

Author Checklist

Reviewers Checklist

amaury1093 left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

amaury1093 Dec 7, 2021 • edited Loading

Choose a reason for hiding this comment

i-norden left a comment

Choose a reason for hiding this comment

amaury1093 commented Dec 7, 2021

atheeshp commented Oct 6, 2021 •

edited by amaury1093

Loading

1. Add an `--aux` flag to all tx command.

2. Add a new `aux-to-fee` subcommand

amaury1093 Dec 7, 2021 •

edited

Loading