Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authz add query all grants by granter #10326

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Oct 8, 2021

Description

Closes: #9966


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #10326 (c6236d2) into master (7e6151e) will increase coverage by 0.11%.
The diff coverage is 92.35%.

❗ Current head c6236d2 differs from pull request most recent head 8f68775. Consider uploading reports for the commit 8f68775 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10326      +/-   ##
==========================================
+ Coverage   64.15%   64.26%   +0.11%     
==========================================
  Files         572      572              
  Lines       53985    54142     +157     
==========================================
+ Hits        34632    34795     +163     
+ Misses      17377    17366      -11     
- Partials     1976     1981       +5     
Impacted Files Coverage Δ
x/authz/keeper/grpc_query.go 70.29% <67.56%> (-1.58%) ⬇️
x/authz/client/testutil/grpc.go 98.26% <100.00%> (+0.74%) ⬆️
x/authz/client/testutil/query.go 100.00% <100.00%> (ø)
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️

@aleem1314 aleem1314 marked this pull request as ready for review October 8, 2021 12:59
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just small nits.

x/authz/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/authz/client/cli/query.go Show resolved Hide resolved
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com>
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 11, 2021
@mergify mergify bot merged commit 3637270 into master Oct 11, 2021
@mergify mergify bot deleted the aleem/9966-authz-granter-grants branch October 11, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/authz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(authz) Keeper function to iterate all grant of granter
4 participants