Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Only do memory allocation when zero coin is found #10339

Merged
merged 8 commits into from
Oct 13, 2021
Merged

perf: Only do memory allocation when zero coin is found #10339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80fb841
Added anohter loop to check if a zero coin exists before allocating s…
waggonerjake Oct 11, 2021
d32d000
Updated CHANGELOG.md
waggonerjake Oct 11, 2021
a3a775e
Merge branch 'master' into jakewagg/zeroCoins
waggonerjake Oct 13, 2021
5b93ecf
Updated changelog and result slice declaration
waggonerjake Oct 13, 2021
d640147
Move initialization after the scan loop
waggonerjake Oct 13, 2021
1656d91
Merge branch 'master' into jakewagg/zeroCoins
waggonerjake Oct 13, 2021
78e38b2
Add a check for 0 length slice
waggonerjake Oct 13, 2021
11597f0
Merge branch 'jakewagg/zeroCoins' of https://github.com/waggonerjake/…
waggonerjake Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* [\#9699](https://github.com/cosmos/cosmos-sdk/pull/9699) Add `:`, `.`, `-`, and `_` as allowed characters in the default denom regular expression.
* (genesis) [\#9697](https://github.com/cosmos/cosmos-sdk/pull/9697) Ensure `InitGenesis` returns with non-empty validator set.
* [\#10262](https://github.com/cosmos/cosmos-sdk/pull/10262) Remove unnecessary logging in `x/feegrant` simulation.
* [\#10339](https://github.com/cosmos/cosmos-sdk/pull/10339) Improve performance of `removeZeroCoins` by only allocating memory when necessary
* [\#10341](https://github.com/cosmos/cosmos-sdk/pull/10341) Move from `io/ioutil` to `io` and `os` packages.

### Bug Fixes
Expand Down
13 changes: 12 additions & 1 deletion types/coin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,18 @@ func (coins Coins) negative() Coins {

// removeZeroCoins removes all zero coins from the given coin set in-place.
func removeZeroCoins(coins Coins) Coins {
result := make([]Coin, 0, len(coins))
for i := 0; i < len(coins); i++ {
if coins[i].IsZero() {
break
} else if i == len(coins)-1 {
return coins
}
}
waggonerjake marked this conversation as resolved.
Show resolved Hide resolved

var result []Coin
if len(coins) > 0 {
result = make([]Coin, 0, len(coins)-1)
}

for _, coin := range coins {
if !coin.IsZero() {
Expand Down