Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove gov keeper.MustMarshal #10373

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Conversation

robert-zaremba
Copy link
Collaborator

@robert-zaremba robert-zaremba commented Oct 15, 2021

Description

Cleaning API. Must* methods should be avoided in a public interface, especially if they are used only in one place.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #10373 (4438dcd) into master (3c85944) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10373      +/-   ##
==========================================
- Coverage   64.28%   64.27%   -0.01%     
==========================================
  Files         572      572              
  Lines       54239    54230       -9     
==========================================
- Hits        34867    34859       -8     
+ Misses      17390    17389       -1     
  Partials     1982     1982              
Impacted Files Coverage Δ
x/gov/keeper/proposal.go 79.71% <33.33%> (-1.25%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACk. Thank you for this cleanup

CHANGELOG.md Outdated Show resolved Hide resolved
@robert-zaremba
Copy link
Collaborator Author

It came after reading more about gov router.

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@robert-zaremba robert-zaremba added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 15, 2021
@robert-zaremba robert-zaremba merged commit 717dcdf into master Oct 15, 2021
@robert-zaremba robert-zaremba deleted the robert/gov-mustmarshal branch October 15, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants