Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add upgrade proposal plan validation to CLI #10379

Merged
merged 47 commits into from
Nov 12, 2021
Merged

feat: Add upgrade proposal plan validation to CLI #10379

merged 47 commits into from
Nov 12, 2021

Commits on Oct 13, 2021

  1. [10286]: Create planinfo.go to house some validation pieces related t… 

    …o upgrade plan info.
    @dwedul-figure
    dwedul-figure committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    ac64aa1 View commit details
    Browse the repository at this point in the history

  2. [10286]: Update the cli software-upgrade process to have a --no-valid… 

    …ate flag and validate the plan info by default.
    @dwedul-figure
    dwedul-figure committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    22886b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. [10286]: Refactor the new planinfo.go stuff to make it hopefully hand… 

    …ier for reuse by cosmovisor. Also, add a --daemon-name flag to the software-upgrade. The deamon name is needed in order to properly validate the plan info. It defaults to the name of the running executable, but since that might not be right, the flag allows defining it.
    @dwedul-figure
    dwedul-figure committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7cfac32 View commit details
    Browse the repository at this point in the history

  2. [10286]: Switch up the --daemon-name flag a bit. Just use the DAEMON_… 

    …NAME env var as the default if it's set, then there isn't a need for a special getter for that flag's value.
    @dwedul-figure
    dwedul-figure committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    4ce1a17 View commit details
    Browse the repository at this point in the history

  3. [10286]: Add github.com/hashicorp/go-getter v1.4.1 to the main go.mod… 

    … file. It's in the cosmovisor go.mod file, but similar functionality is needed in the x/upgrade module now.
    @dwedul-figure
    dwedul-figure committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    5c869f5 View commit details
    Browse the repository at this point in the history

  4. [10286]: Move the planinfo.go file into a new planinfo folder/package… 

    …, and split out the downloading functions into a new downloader.go file. Change PlanInfo.ValidateBasic to ValidateFull that does both the validation pieces on the binaries map.
    @dwedul-figure
    dwedul-figure committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    04d2f54 View commit details
    Browse the repository at this point in the history

  5. [10286]: Prep and plan some new unit tests on the new stuff.

    @dwedul-figure
    dwedul-figure committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    161fff8 View commit details
    Browse the repository at this point in the history

  6. [10286]: Update the flag descriptions of the new flags.

    @dwedul-figure
    dwedul-figure committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    581e32b View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. [10286]: Start work on some unit tests.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    b67858d View commit details
    Browse the repository at this point in the history

  2. [10286]: Require a checksum query parameter in the URLs.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    65b84a8 View commit details
    Browse the repository at this point in the history

  3. [10286]: For the binaries map URLs, use make sure there's a checksum … 

    …in them.
    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    6f3175b View commit details
    Browse the repository at this point in the history

  4. [10286]: Finish up unit tests on download.go.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    b646d58 View commit details
    Browse the repository at this point in the history

  5. [10286]: Fix wording of no-validate flag.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    0b835f8 View commit details
    Browse the repository at this point in the history

  6. [10286]: Fix some wording on the daemon-name flag.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    7a7f795 View commit details
    Browse the repository at this point in the history

  7. [10286]: Move the makeFileURL out of the function it's in so it can b… 

    …e used in other tests.
    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    71abcf6 View commit details
    Browse the repository at this point in the history

  8. [10286]: Create plan info unit tests.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    8d5cec9 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into dwedul/10286-upgrade-prop-validation 

    # Conflicts:
#	go.sum
    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    604a5be View commit details
    Browse the repository at this point in the history

  10. [10286]: gofmt the new unit test files.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    aecbdda View commit details
    Browse the repository at this point in the history

  11. [10286]: Add changelog line for issue 10286.

    @dwedul-figure
    dwedul-figure committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    3ad28b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. [10286]: Get rid of the package global osArchRx and make it just a va… 

    …riable in the one function that needs it.
    @dwedul-figure
    dwedul-figure committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    2d727d1 View commit details
    Browse the repository at this point in the history

  2. [10286]: Rename planinfo.go to plan_info.go

    @dwedul-figure
    dwedul-figure committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    0860283 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dwedul/10286-upgrade-prop-validation

    @dwedul-figure
    dwedul-figure committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    b7ec6b7 View commit details
    Browse the repository at this point in the history

  4. [10286]: Fail validation if the plan.info string is blank.

    @dwedul-figure
    dwedul-figure committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    3faff93 View commit details
    Browse the repository at this point in the history

  5. [10286]: Add unit test for new blank infoStr error.

    @dwedul-figure
    dwedul-figure committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    13a6cea View commit details
    Browse the repository at this point in the history

  6. [10286]: Update the usage string for the --upgrade-info flag.

    @dwedul-figure
    dwedul-figure committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    4d7384a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Merge branch 'master' into dwedul/10286-upgrade-prop-validation 

    # Conflicts:
#	go.mod
    @dwedul-figure
    dwedul-figure committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    fbc8e65 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Merge branch 'master' into dwedul/10286-upgrade-prop-validation 

    # Conflicts:
#	CHANGELOG.md
    @dwedul-figure
    dwedul-figure committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    233beb3 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Merge branch 'master' into dwedul/10286-upgrade-prop-validation

    @dwedul-figure
    dwedul-figure committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    73ae27a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Merge branch 'master' into dwedul/10286-upgrade-prop-validation

    @dwedul-figure
    dwedul-figure committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    71f1ba1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dwedul/10286-upgrade-prop-validation

    @dwedul-figure
    dwedul-figure committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    7acb128 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Merge branch 'master' into dwedul/10286-upgrade-prop-validation

    @dwedul-figure
    dwedul-figure committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    fda7d0c View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. [10286]: Add a little description of the default for the --daemon-nam… 

    …e flag.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    2f1dfaa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dwedul/10286-upgrade-prop-validation

    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    5a39cad View commit details
    Browse the repository at this point in the history

  3. [10286]: Add comment on the binary operation done to check executable… 

    … bits.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    1fa8830 View commit details
    Browse the repository at this point in the history

  4. [10286]: Update comment on DownloadUpgrade to provide more information.

    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    fff68d4 View commit details
    Browse the repository at this point in the history

  5. [10286]: Update the comment on EnsureBinary to have more details.

    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    5176c9d View commit details
    Browse the repository at this point in the history

  6. [10286]: Rename checkURL to validateIsURLWithChecksum to be clearer a… 

    …bout what it's doing.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    89efbb1 View commit details
    Browse the repository at this point in the history

  7. [10286]: Rename downloadUpgradeAsDir to downloadUpgradeAsArchive sinc… 

    …e that's more accurate to what the url must be.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    236af7d View commit details
    Browse the repository at this point in the history

  8. [10286]: Rename DownloadPlanInfoFromURL to DownloadURLWithChecksum an… 

    …d make the error messages a little more generic.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    34781f8 View commit details
    Browse the repository at this point in the history

  9. [10286]: Update error message from 'plan info cannot be blank' to 'pl… 

    …an info must not be blank'.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    4cdeb58 View commit details
    Browse the repository at this point in the history

  10. [10286]: Move the x/upgrade/types/planinfo stuff into x/upgrade/plan … 

    …and rename PlanInfo to just Info.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    482c9f1 View commit details
    Browse the repository at this point in the history

  11. [10286]: Remove the punctuation at the end of the new software-upgrad… 

    …e flag descriptions since the others don't have it and the default is added to the end of that string making it weird with punctuation.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    716bc54 View commit details
    Browse the repository at this point in the history

  12. [10286]: Add a little more to the --daemon-name description to hopefu… 

    …lly prevent some ambiguity.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    26093e8 View commit details
    Browse the repository at this point in the history

  13. [10286]: Make validateIsURLWithChecksum public since it's now named b… 

    …etter.
    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    61706d7 View commit details
    Browse the repository at this point in the history

  14. [10286]: Fix unit test that broke due to change.

    @dwedul-figure
    dwedul-figure committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    2641576 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Merge branch 'master' into dwedul/10286-upgrade-prop-validation

    @dwedul-figure
    dwedul-figure committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    320d49f View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Merge branch 'master' into dwedul/10286-upgrade-prop-validation 

    # Conflicts:
#	go.mod
#	go.sum
    @dwedul-figure
    dwedul-figure committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    382a137 View commit details
    Browse the repository at this point in the history