-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move stuff from types to auth #1049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes a lot of sense to me. I might even suggest to have a top level dir auth
and to move x/auth
to auth/std
. If an alternative replay-protection + signing structure comes to bear, it could be auth/non-std
or whatever ...
@rigelrozanski is this good to merge now re #1047 (comment) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still left as far as I can tell: Implement GetFees and ClearFees in auth keeper - oh and clear testing on it!
@ebuchman nope - we are in agreement of the solution from the conversation but it needs to be implemented ^ see re-review comment |
@rigelrozanski Should that be added in this same PR or in a separate PR? Created an issue for it: #1058 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, fees can be in this PR or not, fine either way IMO
@sunnya97 If it's in another PR we should add back the |
LGTM |
@rigelrozanski Ok, see #1064 |
Fee Collection in auth
Codecov Report
@@ Coverage Diff @@
## develop #1049 +/- ##
==========================================
+ Coverage 60.58% 60.88% +0.3%
==========================================
Files 79 81 +2
Lines 3968 4024 +56
==========================================
+ Hits 2404 2450 +46
- Misses 1405 1412 +7
- Partials 159 162 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - just updated the changelog too
* Update DOCS_README with switch to GH Actions * update to repo makefile Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
This PR looks likes there's a lot more changes than there actually are, because of having to rename the package name prefix across many many files.
The primary goal of this PR is I move the stuff that's specific to the auth anteHandler to the auth module rather than the types folder. This includes:
Related to this organization, I also: