feat: create v1beta2 gov proto types #10589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
reviewed
Nov 22, 2021
cmwaters
changed the title
|
@aaronc did you also want to have v1beta2 in its own types subdirectory or just v1beta1? This also messes with a lot of the imports |
alexanderbez
approved these changes
Nov 22, 2021
| import "gogoproto/gogo.proto"; | ||
| import "cosmos/gov/v1beta2/gov.proto"; | ||
|
|
||
| option go_package = "github.com/cosmos/cosmos-sdk/x/gov/types"; |
There was a problem hiding this comment.
Is the pattern that the latest version is just used as /types with no version in the package?
There was a problem hiding this comment.
This is what I've defaulted to doing but also a question I had myself
There was a problem hiding this comment.
Well I don't actually think we have a good pattern right now. I proposed a pattern here which just uses the proto package as the go package more or less: #10582. But that's a bigger refactoring. And for now this seems the most logical and least intrusive. But open to other suggestions
aaronc
approved these changes
Nov 22, 2021
cmwaters
force-pushed
the
callum/gov-proto
branch
from
7924a30 to
e3446e6
Compare
cmwaters
force-pushed
the
callum/gov-proto
branch
from
e3446e6 to
b4fb8be
Compare
|
@aaronc I decided to revert the proto generation changes. I would have spent all day trying to get all the imports to work and it would basically end up looking mostly like the original PR |
|
I think we have to revert this pr on master as its blocking people from generating new Proto files. |
tac0turtle
added a commit
that referenced
this pull request
Nov 26, 2021
This reverts commit ed01c21.
blewater
pushed a commit
to e-money/cosmos-sdk
that referenced
this pull request
Dec 8, 2021
## Description Ref: cosmos#9810 Bumps gov proto files to v1beta2 and creates new `Proposal` type --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #9810
Bumps gov proto files to v1beta2 and creates new
ProposaltypeAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change