Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should revert tx when block gas limit exceeded #10770

Merged
merged 4 commits into from
Jan 11, 2022
Merged

fix: should revert tx when block gas limit exceeded #10770

merged 4 commits into from
Jan 11, 2022

Commits on Jan 8, 2022

  1. revert tx when block gas limit exceeded 

    Closes: cosmos#10769
Solution:
- create a `WithBranchedStore` to handle state snapshot and revert
- extract `ConsumeBlockGasMiddleware` out from `RecoveryTxMiddleware`.
- order the middlewares properly.

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

Apply suggestions from code review

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
    @yihuang @robert-zaremba
    yihuang and robert-zaremba committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    6baba7e View commit details
    Browse the repository at this point in the history

  2. Update x/auth/middleware/branch_store_test.go 

    Co-authored-by: Robert Zaremba <robert@zaremba.ch>
    @yihuang @robert-zaremba
    yihuang and robert-zaremba committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    c03ab15 View commit details
    Browse the repository at this point in the history

  3. add gas overflow test case

    @yihuang
    yihuang committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    af0cc18 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Merge branch 'master' into block-gas-meter-panic

    @mergify
    mergify[bot] authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    2f24333 View commit details
    Browse the repository at this point in the history