Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds pruning for feegrant #10830

Merged
merged 55 commits into from
Feb 8, 2022
Merged

feat: adds pruning for feegrant #10830

merged 55 commits into from
Feb 8, 2022

Conversation

atheeshp
Copy link
Contributor

Closes: #10685


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review December 23, 2021 05:44
x/feegrant/fees.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 self-assigned this Jan 3, 2022
@atheeshp
Copy link
Contributor Author

atheeshp commented Jan 3, 2022

@robert-zaremba can you take a look at this PR?

x/feegrant/basic_fee.go Show resolved Hide resolved
x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved
x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved
x/feegrant/keeper/keeper.go Show resolved Hide resolved
x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved
x/feegrant/keeper/keeper.go Outdated Show resolved Hide resolved
x/feegrant/migrations/v045/store.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the C:x/gov label Jan 27, 2022
x/feegrant/key.go Outdated Show resolved Hide resolved
x/feegrant/migrations/v045/keys.go Outdated Show resolved Hide resolved
x/feegrant/migrations/v045/store.go Outdated Show resolved Hide resolved
x/feegrant/key.go Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from amaury1093 January 31, 2022 16:24
@robert-zaremba robert-zaremba added this to the v0.46 milestone Feb 2, 2022
@robert-zaremba robert-zaremba mentioned this pull request Feb 2, 2022
56 tasks
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, to remove the [1:], which makes the code confusing to read IMO.

x/feegrant/spec/01_concepts.md Outdated Show resolved Hide resolved
x/feegrant/keeper/grpc_query.go Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's add a state-mcahine breaking entry, and we're good to go

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 7, 2022
@mergify mergify bot merged commit 786afb3 into master Feb 8, 2022
@mergify mergify bot deleted the ap/feegrant-pruning branch February 8, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/feegrant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for feegrant pruning
6 participants