feat: support custom mnemonics in in-process testing network (backport #10922) #10935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
## Description In certain cases, it proves to be beneficial to be able to support user provided mnemonics in the in-process testing network. This essentially allows you to know the validator addresses ahead of time in case you need to do any custom genesis logic (e.g. Gravity Bridge delegation keys). --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit b019083) # Conflicts: # server/init.go # testutil/network/network.go
|
This pull request introduces 8 alerts when merging 21afe02 into cd24419 - view on LGTM.com new alerts:
|
|
here too |
alexanderbez
approved these changes
Jan 13, 2022
|
I'm gonna assume |
amaury1093
reviewed
Jan 14, 2022
| func GenerateSaveCoinKey(keybase keyring.Keyring, keyName string, overwrite bool, algo keyring.SignatureAlgo) (sdk.AccAddress, string, error) { | ||
| func GenerateSaveCoinKey( | ||
| keybase keyring.Keyring, | ||
| keyName, mnemonic string, |
There was a problem hiding this comment.
Ah, this is technically API-breaking and shouldn't have been backported.
Who's really needing this change? If yes, then I'll put some big signs on the Release Notes; if not, then we can revert it?
There was a problem hiding this comment.
Sounds like we should move this function to testutils, it's only used in tests.
There was a problem hiding this comment.
For non-breaking change, we can also create a new GenerateSaveCoinKeyWithMnemo() for 0.44 and 0.45. @alexanderbez I'm gonna let you decide if we revert or make a non-breaking change.
There was a problem hiding this comment.
tbh, I would move this function away to testutils in 0.45
There was a problem hiding this comment.
Moving this to testutils seems like a good approach. I would like to see these in 0.44 and 0.45 regardless, so ACK on @robert-zaremba's proposal 👍
19 tasks
amaury1093
added a commit
that referenced
this pull request
Feb 2, 2022
jiujiteiro
pushed a commit
to realiotech/cosmos-sdk
that referenced
this pull request
May 6, 2022
jiujiteiro
pushed a commit
to realiotech/cosmos-sdk
that referenced
this pull request
May 6, 2022
…port cosmos#10922) (cosmos#10935)" (cosmos#11083) This reverts commit 8bb7a96.
jiujiteiro
pushed a commit
to realiotech/cosmos-sdk
that referenced
this pull request
May 10, 2022
jiujiteiro
pushed a commit
to realiotech/cosmos-sdk
that referenced
this pull request
May 10, 2022
…port cosmos#10922) (cosmos#10935)" (cosmos#11083) This reverts commit 8bb7a96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #10922 done by Mergify.
Cherry-pick of b019083 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com