fix: reject query with block height in the future #11222

yihuang · 2022-02-18T08:36:22Z

Description

Should be good to backport to older versions.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Closes: cosmos#11220

tac0turtle

LGTM, could you add a changelog entry please

yihuang · 2022-02-18T09:02:40Z

LGTM, could you add a changelog entry please

done, unit tests and changelog added.

tac0turtle · 2022-02-22T15:39:03Z

@yihuang can you fix the failing test

-- FAIL: TestBaseAppCreateQueryContext/valid_height (0.00s)
[177](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:177)
        abci_test.go:150: 
[178](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:178)
            	Error Trace:	abci_test.go:150
[179](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:179)
            	Error:      	Received unexpected error:
[180](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:180)
            	            	
[181](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:181)
            	            	github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).createQueryContext
[182](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:182)
            	            		/home/runner/work/cosmos-sdk/cosmos-sdk/baseapp/abci.go:643
[183](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:183)
            	            	github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).CreateQueryContext
[184](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:184)
            	            		/home/runner/work/cosmos-sdk/cosmos-sdk/baseapp/util_test.go:52
[185](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:185)
            	            	github.com/cosmos/cosmos-sdk/baseapp_test.TestBaseAppCreateQueryContext.func1
[186](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:186)
            	            		/home/runner/work/cosmos-sdk/cosmos-sdk/baseapp/abci_test.go:146
[187](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:187)
            	            	cannot query with proof when height <= 1; please provide a valid height: invalid request
[188](https://github.com/cosmos/cosmos-sdk/runs/5290169931?check_suite_focus=true#step:6:188)
            	Test:       	TestBaseAppCreateQueryContext/valid_height

alexanderbez

LGTM!

IIRC, there can sometimes be a off-by-one difference between the current block height and what app.LastBlockHeight() returns. Have you tested this on a local network or even a live one?

yihuang · 2022-02-23T01:46:23Z

LGTM!

IIRC, there can sometimes be a off-by-one difference between the current block height and what app.LastBlockHeight() returns. Have you tested this on a local network or even a live one?

Do you mean the off-by-one difference between tendermint and app? yeah, we have observed that in production, the solution for the client is just to try again later. But with this patch, they receive a clear error message rather than a panic in such case.

yihuang · 2022-02-23T01:50:05Z

@yihuang can you fix the failing test

fixed, increased the height by one.

yihuang · 2022-02-24T01:08:53Z

can we backport to 0.45? @marbar3778

tac0turtle · 2022-02-24T15:14:00Z

@Mergifyio backport release/v0.45.x

## Description Closes: #11220 Should be good to backport to older versions. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 6324b5a) # Conflicts: # CHANGELOG.md # baseapp/abci_test.go

mergify · 2022-02-24T15:14:56Z

backport release/v0.45.x

✅ Backports have been created

#11266 fix: reject query with block height in the future (backport #11222) has been created for branch release/v0.45.x

…11266) * fix: reject query with block height in the future (#11222) ## Description Closes: #11220 Should be good to backport to older versions. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 6324b5a) # Conflicts: # CHANGELOG.md # baseapp/abci_test.go * fix conflicts Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

) (cosmos#11266) * fix: reject query with block height in the future (cosmos#11222) ## Description Closes: cosmos#11220 Should be good to backport to older versions. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 6324b5a) # Conflicts: # CHANGELOG.md # baseapp/abci_test.go * fix conflicts Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

reject query with block height in the future

ebde047

Closes: cosmos#11220

yihuang requested review from aaronc and alexanderbez as code owners February 18, 2022 08:36

tac0turtle approved these changes Feb 18, 2022

View reviewed changes

tac0turtle changed the title ~~reject query with block height in the future~~ fix: reject query with block height in the future Feb 18, 2022

yihuang added 2 commits February 18, 2022 16:46

unit tests

0524acd

changelog

9745b95

tac0turtle added 2 commits February 18, 2022 11:40

Merge branch 'master' into query-future-height

3bfa1bc

Merge branch 'master' into query-future-height

ffe4e64

tac0turtle requested review from atheeshp and amaury1093 February 21, 2022 15:59

tac0turtle added 2 commits February 21, 2022 17:11

Merge branch 'master' into query-future-height

1140a81

Merge branch 'master' into query-future-height

40489e4

alexanderbez approved these changes Feb 22, 2022

View reviewed changes

fix unit tests

6a1f703

Merge branch 'master' into query-future-height

b11a008

tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 23, 2022

mergify bot merged commit 6324b5a into cosmos:master Feb 24, 2022

yihuang deleted the query-future-height branch February 24, 2022 01:08

mergify bot mentioned this pull request Feb 24, 2022

fix: reject query with block height in the future (backport #11222) #11266

Merged

faddat mentioned this pull request Feb 28, 2022

v0.45.x akash-network/cosmos-sdk#176

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: reject query with block height in the future #11222

fix: reject query with block height in the future #11222

yihuang commented Feb 18, 2022

tac0turtle left a comment

yihuang commented Feb 18, 2022

tac0turtle commented Feb 22, 2022

alexanderbez left a comment

yihuang commented Feb 23, 2022 •

edited

Loading

yihuang commented Feb 23, 2022 •

edited

Loading

yihuang commented Feb 24, 2022 •

edited

Loading

tac0turtle commented Feb 24, 2022

mergify bot commented Feb 24, 2022

fix: reject query with block height in the future #11222

fix: reject query with block height in the future #11222

Conversation

yihuang commented Feb 18, 2022

Description

Author Checklist

Reviewers Checklist

tac0turtle left a comment

Choose a reason for hiding this comment

yihuang commented Feb 18, 2022

tac0turtle commented Feb 22, 2022

alexanderbez left a comment

Choose a reason for hiding this comment

yihuang commented Feb 23, 2022 • edited Loading

yihuang commented Feb 23, 2022 • edited Loading

yihuang commented Feb 24, 2022 • edited Loading

tac0turtle commented Feb 24, 2022

mergify bot commented Feb 24, 2022

✅ Backports have been created

yihuang commented Feb 23, 2022 •

edited

Loading

yihuang commented Feb 23, 2022 •

edited

Loading

yihuang commented Feb 24, 2022 •

edited

Loading