Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case unauthorized message #11229

Merged
merged 12 commits into from
Feb 24, 2022
Merged

fix: case unauthorized message #11229

merged 12 commits into from
Feb 24, 2022

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Feb 18, 2022

Description

Closes: #10559
see tendermint changes


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

client/broadcast.go Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from amaury1093 February 19, 2022 08:49
client/broadcast.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add a changelog entry?

@atheeshp atheeshp marked this pull request as ready for review February 24, 2022 11:46
@tac0turtle tac0turtle merged commit ef6fed6 into master Feb 24, 2022
@tac0turtle tac0turtle deleted the ap/feegrant-fix branch February 24, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/feegrant: fix timeout on test case after TM v0.35 integration
3 participants