Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: abstractions for snapshot and pruning; snapshot intervals eventually pruned; unit tests #11496

Merged
merged 66 commits into from
Apr 21, 2022
Merged

refactor!: abstractions for snapshot and pruning; snapshot intervals eventually pruned; unit tests #11496

merged 66 commits into from
Apr 21, 2022

Commits on Apr 13, 2022

  1. refactor: abstractions for snapshot and pruning; snapshot intervals a… 

    …re eventually pruned; unit tests
    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    8261885 View commit details
    Browse the repository at this point in the history

  2. fix GetBlockRetentionHeight

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    271314a View commit details
    Browse the repository at this point in the history

  3. avoid snapshots/store implementing Store interface

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    640c7a6 View commit details
    Browse the repository at this point in the history

  4. always use testutil.GetTempDir for creating a temp dir in tests

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    bc55f11 View commit details
    Browse the repository at this point in the history

  5. use os.MkdirTemp for creating temp dir

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    5613d2a View commit details
    Browse the repository at this point in the history

  6. changelog

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a0d29c6 View commit details
    Browse the repository at this point in the history

  7. rename pruningTypes to pruningtypes

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d7449dd View commit details
    Browse the repository at this point in the history

  8. rename snapshotTypes to snapshotypes

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    aef77b5 View commit details
    Browse the repository at this point in the history

  9. update pruning default with correct values, update pruning everything… 

    … description in command
    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a7c0311 View commit details
    Browse the repository at this point in the history

  10. fix pruning options unit test to reflect the updated default value

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d66ed29 View commit details
    Browse the repository at this point in the history

  11. address functional and security related comments

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d12d255 View commit details
    Browse the repository at this point in the history

  12. storetypes

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    8e420a7 View commit details
    Browse the repository at this point in the history

  13. snapshottypes

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    4e66ff3 View commit details
    Browse the repository at this point in the history

  14. restore import order in abci_test.go

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    c314381 View commit details
    Browse the repository at this point in the history

  15. import order in basepp_test.go

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    fff18ad View commit details
    Browse the repository at this point in the history

  16. import order in baseapp/options.go

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    99c303a View commit details
    Browse the repository at this point in the history

  17. import order

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    64b9f35 View commit details
    Browse the repository at this point in the history

  18. make format on changed files

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    55bac3b View commit details
    Browse the repository at this point in the history

  19. add unit test for NewPruningOptionsFromString

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a54fd34 View commit details
    Browse the repository at this point in the history

  20. add TestLoadPruningHeights_PruneNothing

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    1751e81 View commit details
    Browse the repository at this point in the history

  21. address previousHeight == 0 guard and nits

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    ecde568 View commit details
    Browse the repository at this point in the history

  22. fix snapshot height must be positive check

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    17bcbbd View commit details
    Browse the repository at this point in the history

  23. godoc for init

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    f6462e1 View commit details
    Browse the repository at this point in the history

  24. return 0 if negative previousVersion is given to the pruning manager.… 

    …HandleHeight, add unit tests
    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    20e8651 View commit details
    Browse the repository at this point in the history

  25. remove GetCommitKVStores

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d915e89 View commit details
    Browse the repository at this point in the history

  26. remove type aliases from store types

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    2ec8fad View commit details
    Browse the repository at this point in the history

  27. revert pruning options pointer

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    950ab26 View commit details
    Browse the repository at this point in the history

  28. revert snapshot options pointer

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    1c7b5a9 View commit details
    Browse the repository at this point in the history

  29. refactor: syncronize pruning manager (#187) 

    * progress

* refactor pruning manager to have no data races; flush heights immediately when updated in memory; unit tests

* typo in TestMultiStore_PruningRestart

* fmt

* improve comments

* avoid mutex init, move comments to struct declaration, return nil with error, fix logs
    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    fdf3515 View commit details
    Browse the repository at this point in the history

  30. fix rebase problem in tests

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d9eb77c View commit details
    Browse the repository at this point in the history

  31. increase code coverage by covering panics in pruning manager unit tests

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    cd5ed77 View commit details
    Browse the repository at this point in the history

  32. increase coverage in pruning options

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    1a62435 View commit details
    Browse the repository at this point in the history

  33. NegativeHeightsError implementation and format

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    9400186 View commit details
    Browse the repository at this point in the history

  34. Update pruning/README.md 

    Co-authored-by: Peter Bourgon <peterbourgon@users.noreply.github.com>
    @p0mvn @peterbourgon
    p0mvn and peterbourgon authored Apr 13, 2022
    Configuration menu
    Copy the full SHA
    94739dc View commit details
    Browse the repository at this point in the history

  35. update order of declarations in pruning manager

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    631a756 View commit details
    Browse the repository at this point in the history

  36. Merge branch 'roman/upstream/snapshot-pruning-refactor' of github.com… 

    …:osmosis-labs/cosmos-sdk into roman/upstream/snapshot-pruning-refactor
    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    ffa4d6d View commit details
    Browse the repository at this point in the history

  37. new goroutine is handled by SnapshotIfApplicable caller

    @p0mvn
    p0mvn committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    5a504af View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. synchronous SnapshotIfApplicable

    @p0mvn
    p0mvn committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    2893b32 View commit details
    Browse the repository at this point in the history

  2. return a copy of pruneHeights in GetFlushAndResetPruningHeights

    @p0mvn
    p0mvn committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    25b4bd1 View commit details
    Browse the repository at this point in the history

  3. godoc for pruning manager

    @p0mvn
    p0mvn committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    7f610e1 View commit details
    Browse the repository at this point in the history

  4. Update error message in baseapp/baseapp.go 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    9c92dc4 View commit details
    Browse the repository at this point in the history

  5. sdk import in util_test.go

    @p0mvn
    p0mvn committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8ef356b View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review in pruning/README.md 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c482cd3 View commit details
    Browse the repository at this point in the history

  7. Apply more style suggestions from code review 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez authored Apr 14, 2022
    Configuration menu
    Copy the full SHA
    091061c View commit details
    Browse the repository at this point in the history

  8. remove junk test files

    @p0mvn
    p0mvn committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    f2ea6b0 View commit details
    Browse the repository at this point in the history

  9. style fix in simapp/simd/cmd/root.go

    @p0mvn
    p0mvn committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    611560f View commit details
    Browse the repository at this point in the history

  10. remove unused import in baseapp

    @p0mvn
    p0mvn committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    678ed17 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. Merge branch 'master' into roman/upstream/snapshot-pruning-refactor

    @p0mvn
    p0mvn committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    a6c861a View commit details
    Browse the repository at this point in the history

  2. resolve merge conflict

    @p0mvn
    p0mvn committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    dab1ba8 View commit details
    Browse the repository at this point in the history

  3. update snapshots/README.md

    @p0mvn
    p0mvn committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    d40790c View commit details
    Browse the repository at this point in the history

  4. Update SnapshotIntervalOff comment in snapshots/types/options.go 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez authored Apr 16, 2022
    Configuration menu
    Copy the full SHA
    54068ce View commit details
    Browse the repository at this point in the history

  5. Update pruneSnapshotHeightsKey pruning/manager.go 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez authored Apr 16, 2022
    Configuration menu
    Copy the full SHA
    70c2043 View commit details
    Browse the repository at this point in the history

  6. update SetSnapshotInterval comment

    @p0mvn
    p0mvn committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    f3b5485 View commit details
    Browse the repository at this point in the history

  7. remove snapshot store type

    @p0mvn
    p0mvn committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    2023fa3 View commit details
    Browse the repository at this point in the history

  8. remove pruning and snapshot wrappers from store types

    @p0mvn
    p0mvn committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    823971f View commit details
    Browse the repository at this point in the history

  9. fix HandleHeight comment in pruning manager

    @p0mvn
    p0mvn committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    73b75ee View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge branch 'master' into roman/upstream/snapshot-pruning-refactor

    @p0mvn
    p0mvn committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    986f6ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into roman/upstream/snapshot-pruning-refactor

    @p0mvn
    p0mvn committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    19669c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. snapshot happens in a separate goroutine

    @p0mvn
    p0mvn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    bbe9d5e View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Merge branch 'master' into roman/upstream/snapshot-pruning-refactor

    @p0mvn
    p0mvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    073b664 View commit details
    Browse the repository at this point in the history

  2. set snapshot interval on multistore in baseapp instead of snapshot ma… 

    …nager
    @p0mvn
    p0mvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2dc26e5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into roman/upstream/snapshot-pruning-refactor

    @p0mvn
    p0mvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d6a3569 View commit details
    Browse the repository at this point in the history

  4. fix snapshot manager unit tests

    @p0mvn
    p0mvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8eee2f7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into roman/upstream/snapshot-pruning-refactor

    @p0mvn
    p0mvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5d85f99 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into roman/upstream/snapshot-pruning-refactor

    @alexanderbez
    alexanderbez authored Apr 21, 2022
    Configuration menu
    Copy the full SHA
    eb5a3b3 View commit details
    Browse the repository at this point in the history

  7. Update CHANGELOG.md 

    Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
    @p0mvn @alexanderbez
    p0mvn and alexanderbez authored Apr 21, 2022
    Configuration menu
    Copy the full SHA
    e53691a View commit details
    Browse the repository at this point in the history