revert: replace all ModuleCdc instances with legacy.Cdc

[RiccardoM]

Description

Reverts the usage of a singleton legacy.Cdc codec while (de)serializing x/authz messages.

Closes: #11643

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[RiccardoM]

I've created this new package in order to avoid any possible dependency cycle that might arise if we leave the ModuleCdc definition inside the x/authz/codec.go file. If you think we can keep it inside x/authz/codec.go then I can move it there without any issue

[amaury1093]

to avoid any possible dependency cycle that might arise if we leave the ModuleCdc definition inside the x/authz/codec.go

Which dep cycle do you see happening?

By default, I would say let's keep like all other modules, unless there's a strong reason to do a separate package.

[RiccardoM]

Ok I've just tried moving it back to authz/codec.go and the following popped up:

package github.com/cosmos/cosmos-sdk/server
        imports github.com/cosmos/cosmos-sdk/server/rosetta
        imports github.com/cosmos/cosmos-sdk/x/auth/tx
        imports github.com/cosmos/cosmos-sdk/x/auth/middleware
        imports github.com/cosmos/cosmos-sdk/x/auth/types
        imports github.com/cosmos/cosmos-sdk/x/authz
        imports github.com/cosmos/cosmos-sdk/x/auth/types: import cycle not allowed
package github.com/cosmos/cosmos-sdk/server
        imports github.com/cosmos/cosmos-sdk/server/rosetta
        imports github.com/cosmos/cosmos-sdk/x/auth/tx
        imports github.com/cosmos/cosmos-sdk/x/auth/middleware
        imports github.com/cosmos/cosmos-sdk/x/auth/types
        imports github.com/cosmos/cosmos-sdk/x/authz
        imports github.com/cosmos/cosmos-sdk/x/auth/types: import cycle not allowed

[amaury1093]

Nice! Can we add a comment somewhere saying that authz's codec is in a separate package to avoid dep cycle? Maybe a package godoc

[RiccardoM]

@AmauryM @alexanderbez documentation has been added

[RiccardoM]

There is one test failing within the gov module due to the v1/v1beta1 versions that I don't know how to fix. Maybe @AmauryM you can help with it? If I recall correctly you were working on this module

[codecov]

Codecov Report

Merging #11680 (7e9dce8) into master (75d4e41) will increase coverage by 0.03%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master   #11680      +/-   ##
==========================================
+ Coverage   65.84%   65.87%   +0.03%     
==========================================
  Files         667      667              
  Lines       70374    70446      +72     
==========================================
+ Hits        46336    46405      +69     
+ Misses      21347    21346       -1     
- Partials     2691     2695       +4     

Impacted Files	Coverage Δ
x/auth/vesting/types/msgs.go	0.00% <0.00%> (ø)
x/authz/keeper/msg_server.go	0.00% <0.00%> (ø)
x/authz/simulation/operations.go	66.97% <0.00%> (ø)
x/distribution/types/msg.go	60.00% <0.00%> (ø)
x/evidence/types/msgs.go	36.36% <0.00%> (ø)
x/group/msgs.go	52.41% <0.00%> (ø)
x/staking/types/msg.go	53.50% <0.00%> (ø)
x/upgrade/types/msgs.go	55.55% <0.00%> (ø)
x/authz/authorization_grant.go	65.71% <50.00%> (ø)
x/gov/types/v1/msgs.go	63.69% <50.00%> (ø)
... and 24 more

[amaury1093]

LGTM, pending a small comment. Thanks @RiccardoM for this quick PR!

[alexanderbez]

ACK. @RiccardoM can we address this one comment -> https://github.com/cosmos/cosmos-sdk/pull/11680/files#r852836740

cc @zmanian

[alexanderbez]

@AmauryM do we need to backport this at all. Is it in 0.46.x?

[amaury1093]

@Mergifyio backport release/v0.46.x

[mergify]

backport release/v0.46.x

✅ Backports have been created

• #11728 revert: replace all ModuleCdc instances with legacy.Cdc (backport #11680) has been created for branch release/v0.46.x