fix: dockerfile for building proto (#11452)

[robert-zaremba]

github.com/regen-network/cosmos-proto/protoc-gen-gocosmos was missing in the Dockerfile

• fixed the installation with proto cosmos
• updated dependencies
• set the go version to 1.17 (latest is already using 1.18)
• regenerated proto

I know we want to move to buf plugin, but until this is done we have a docker .

---

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[robert-zaremba]

merging again the right docker setup again. Tested it locally and works fine.

@marbar3778 reported some past issue, but I was not able to replicate it. would be good if someone else will test is as well.
cc @julienrbrt

[julienrbrt]

I tested it and it works! However, I wonder why cannot we use directly https://github.com/cosmos/gogoproto like I have tried to do here: #11695

The regen-network repository state that it is deprecated, so why not already move to cosmos one?

(note that for that we need the latest change from master to be tagged: ref cosmos/gogoproto#5 (comment))

[robert-zaremba]

@marbar3778 could you test it? Last time you had some issue.

However, I wonder why cannot we use directly https://github.com/cosmos/gogoproto like I have tried to do here: #11695

Because that causes lots of other changes / incompatibilities, which needs to be handled separately: #11414 .

[amaury1093]

tACK on macos

[alexanderbez]

What's left to get this merged? Or is this merge-able?

[robert-zaremba]

What's left to get this merged? Or is this merge-able?

Marko had some issue with the previous fix... I was not able reproduce it and didn't get more details, so wanted him to to test it.

[robert-zaremba]

@AmauryM test it as well and it worked. So merging.

[robert-zaremba]

now we need to tag 0.7 on the docker hub. @marbar3778 or @alexanderbez can you do that?

[alexanderbez]

now we need to tag 0.7 on the docker hub. @marbar3778 or @alexanderbez can you do that?

Of what image? Also, we should be using ghcr not dockerhub.

If I know the image and how to build it, I can push a tag to ghcr.

[robert-zaremba]

Of what image

tendermintdev/sdk-proto-gen

ghcr not dockerhub.

What's the advantage of ghcr? Maybe let's have a chat on discord?

[faddat]

oh -- ghcr allows it all to be forkable and portable

[alexanderbez]

And it integrates natively into the CI pipeline.