test: fix TestNewAnyWithCustomTypeURLWithErrorNoAllocation test failure #11715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11715 +/- ##
==========================================
- Coverage 65.93% 65.93% -0.01%
==========================================
Files 667 667
Lines 70460 70460
==========================================
- Hits 46460 46459 -1
- Misses 21304 21305 +1
Partials 2696 2696
|
There was a problem hiding this comment.
@julienrbrt can you explain the fix? What does runtime.GC() do in this context and why does it solve the problem?
| @@ -28,6 +28,9 @@ var eom = &errOnMarshal{} | |||
| // Ensure that returning an error doesn't suddenly allocate and waste bytes. | |||
| // See https://github.com/cosmos/cosmos-sdk/issues/8537 | |||
| func TestNewAnyWithCustomTypeURLWithErrorNoAllocation(t *testing.T) { | |||
| // make sure we're not in the middle of a GC. | |||
| runtime.GC() | |||
There was a problem hiding this comment.
So the fix is just to run garbage collection prior to future runtime calls, I see.
alexanderbez
approved these changes
Apr 21, 2022
…eurlwitherrornoallocation-flakey-race-test-failure
alexanderbez
deleted the
julien/11664-tests-testnewanywithcustomtypeurlwitherrornoallocation-flakey-race-test-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11664
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change