-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: master -> main #11730
chore: master -> main #11730
Conversation
@@ -1,3 +1,3 @@ | |||
master master | |||
main main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will break existing links, we should look into redirecting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a bit? Shouldn't links still work as we just renamed the default branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.cosmos.network/master/ the url here would change from master to main, it may invalidate urls and links in other repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not seem that these redirects are working tho: https://github.com/cosmos/cosmos-sdk/blob/main/docs/.vuepress/enhanceApp.js
This PR cannot be merged to this test failing: https://github.com/cosmos/cosmos-sdk/runs/6133701530?check_suite_focus=true This is blocking some other PR btw. |
@alexanderbez feel free to admin merge when you think its ready |
Merged! 🚀 |
Description
Update all references of
master
tomain
, including CI workflows, docs, guides, etc...I'm sure I missed some old docs, but we can update those as we find them in the future. Important part is that we got CI and actions covered.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change